Python: No fieldFlowBranchLimit for SummarizedCallables
#15936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that when - a function has more than one summary (with different charpred) - one summary is subsumed by a subpath (or something happens around the function being extracted) - the function is called multiple times(we needed at least three) one of the summaries would no longer lead to flow.
so python2 also respects it
|
I'm guessing you probably need to implement #15689 for Python. |
Thanks! That did indeed solve it. |
sidshank
changed the title
RasmusWL
approved these changes
Mar 19, 2024
RasmusWL
changed the title
fieldFlowBranchLimit for SummarizedCallables
|
Before we merge though: let's do some testing on performance impact! I think that's the main reason we didn't just implement it when Ruby did:
So we should at least gauge that performance impact |
yoff
added
the
Awaiting evaluation
|
No frightening performance cost (less than 1%), so I shall boldly merge this. |
yoff
removed
the
Awaiting evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that when
one of the summaries would no longer lead to flow.
Fixed by doing the same as Ruby in #15689