C#/Java: Re-factor the model generator to be a parameterized module. #17509
Conversation
michaelnebel
force-pushed
the
modelgen/parammodule
branch
from
12b2877 to
75508d6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
csharp/ql/src/utils/modelgenerator/internal/CaptureModels.qll
Dismissed
Show dismissed
Hide dismissed
michaelnebel
force-pushed
the
modelgen/parammodule
branch
2 times, most recently
from
117287d to
d09948f
Compare
michaelnebel
changed the title
michaelnebel
force-pushed
the
modelgen/parammodule
branch
from
d09948f to
faf6fea
Compare
michaelnebel
force-pushed
the
modelgen/parammodule
branch
from
faf6fea to
f142af5
Compare
michaelnebel
added
the
no-change-note-required
|
DCA looks good! |
| /** | ||
| * A node. | ||
| */ | ||
| class NodeExtended extends Lang::Node { |
There was a problem hiding this comment.
I would just call it Node.
There was a problem hiding this comment.
That will cause a compilation error since both Lang and ModelGeneratorInput are imported (even though Lang is imported inside the DataFlow module).
| @@ -89,5 +89,5 @@ string captureFlow(DataFlowSummaryTargetApi api) { | |||
| string captureNoFlow(DataFlowSummaryTargetApi api) { | |||
| not exists(DataFlowSummaryTargetApi api0 | exists(captureFlow(api0)) and api0.lift() = api.lift()) and | |||
| api.isRelevant() and | |||
| result = Printing::asNeutralSummaryModel(api) | |||
| result = ModelPrinting::asNeutralSummaryModel(api) | |||
There was a problem hiding this comment.
It looks like the contents of this query can also be fully shared?
There was a problem hiding this comment.
The historical reason for not doing so, is because of the language specific examples in the comments. Maybe we should just consider scrapping those as this is now captured in a more readable way in the tests.
| @@ -0,0 +1,909 @@ | |||
| /** | |||
| * INTERNAL: Do not use. | |||
There was a problem hiding this comment.
If that's the case, then better to put this file inside an internal folder.
| result = ModelPrinting::asLiftedValueModel(api, qualifierString(), "ReturnValue") | ||
| } | ||
|
|
||
| private int accessPathLimit0() { result = 2 } |
There was a problem hiding this comment.
I think it would be nice to put all logic related to content-sensitive model generation inside a nested module, say ContentSensitive.
| */ | ||
|
|
||
| private import codeql.dataflow.DataFlow | ||
| private import codeql.dataflow.TaintTracking as Tt |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
In this PR we replace the "pyrameterised" module of the model generator with a parameterised module.
The comments used in the signature module are mostly taken from the C#/Java specific implementation.