Skip to content

C#/Java: Re-factor the model generator to be a parameterized module. #17509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 26, 2024
Merged

C#/Java: Re-factor the model generator to be a parameterized module. #17509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3b9f3c2
Shared: Add a model generator parameterised module.
michaelnebel Sep 18, 2024
1f3b28a
C#: Use the shared model generator implementation.
michaelnebel Sep 18, 2024
2033818
Java: Use the shared model generator implementation.
michaelnebel Sep 18, 2024
de4a7da
Java/C#: No longer sync CaptureModels.qll.
michaelnebel Sep 18, 2024
f142af5
Shared: QL doc improvement.
michaelnebel Sep 19, 2024
22c2522
Shared: Make a ContentSensitive module with predicates and classes re…
michaelnebel Sep 24, 2024
fd45d2d
Shared: Move the model generator implementation to an internal folder.
michaelnebel Sep 24, 2024
e608575
Shared: Put the content of CaptureSummaryFlowQuery into the shared li…
michaelnebel Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions config/identical-files.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@
"java/ql/lib/semmle/code/java/dataflow/internal/rangeanalysis/SsaReadPositionCommon.qll",
"csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/SsaReadPositionCommon.qll"
],
"Model as Data Generation Java/C# - CaptureModels": [
"java/ql/src/utils/modelgenerator/internal/CaptureModels.qll",
"csharp/ql/src/utils/modelgenerator/internal/CaptureModels.qll"
],
"Sign Java/C#": [
"java/ql/lib/semmle/code/java/dataflow/internal/rangeanalysis/Sign.qll",
"csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/Sign.qll"
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/utils/modelgenerator/CaptureContentSummaryModels.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
import internal.CaptureModels

from DataFlowSummaryTargetApi api, string flow
where flow = captureContentFlow(api)
where flow = ContentSensitive::captureFlow(api)
select flow order by flow
2 changes: 0 additions & 2 deletions csharp/ql/src/utils/modelgenerator/CaptureNeutralModels.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
* @tags modelgenerator
*/

import semmle.code.csharp.dataflow.internal.FlowSummaryImpl as FlowSummaryImpl
import internal.CaptureModels
import internal.CaptureSummaryFlowQuery

from DataFlowSummaryTargetApi api, string noflow
where noflow = captureNoFlow(api)
Expand Down
2 changes: 0 additions & 2 deletions csharp/ql/src/utils/modelgenerator/CaptureSummaryModels.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
* @tags modelgenerator
*/

import semmle.code.csharp.dataflow.internal.FlowSummaryImpl as FlowSummaryImpl
import internal.CaptureModels
import internal.CaptureSummaryFlowQuery

from DataFlowSummaryTargetApi api, string flow
where flow = captureFlow(api)
Expand Down
Loading
Loading