Python: Handle iterable unpacking in taint tracking #2700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to looked at PEP 3132 and |
Now we recognize `[(x,y)] = [(1,2)]` -- in itself not a widely used idiom, but more of a warmup excersize for me
RasmusWL
force-pushed
the
python-taint-iterable-unpacking
branch
from
140cf75 to
781024d
Compare
RasmusWL
force-pushed
the
python-taint-iterable-unpacking
branch
from
55b2de1 to
65958b4
Compare
|
Turned out it was fairly easy to add support for PEP 3132, so I just did it 😋 |
RasmusWL
force-pushed
the
python-taint-iterable-unpacking
branch
from
65958b4 to
081d66e
Compare
tausbn
requested changes
Feb 12, 2020
tausbn
approved these changes
Feb 17, 2020
tausbn
added a commit
to tausbn/codeql
that referenced
this pull request
Mar 3, 2020
max-schaefer
pushed a commit
that referenced
this pull request
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal was to support
a,b,c = iterable, but some other things snuck in as well.