Python: Fix or disable CPs introduced by #2700 and #2875. #2973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tausbn
added
Python
Priority
|
This is mostly a hotfix, so that we can progress with the on-going dist upgrade, and so an in-depth review is probably not needed. Just a quick look to see that I haven't done something completely ridiculous. Of course, if you do figure out a solution for the CP that I just removed by brute force (by essentially reverting to the previous behaviour), that would be great. |
|
Ok sounds good. |
BekaValentine
approved these changes
Mar 4, 2020
RasmusWL
reviewed
Mar 5, 2020
Comment on lines
-230
to
240
| private predicate clears_taint(ControlFlowNode final_test, ControlFlowNode tainted, ControlFlowNode test, boolean sense) { | ||
| test_equality_with_const(final_test, tainted, sense) | ||
| private predicate clears_taint(ControlFlowNode tainted, ControlFlowNode test, boolean sense) { | ||
| test_equality_with_const(test, tainted, sense) | ||
| or | ||
| test_in_const_seq(final_test, tainted, sense) | ||
| test_in_const_seq(test, tainted, sense) | ||
| or | ||
| test.(UnaryExprNode).getNode().getOp() instanceof Not and | ||
| exists(ControlFlowNode nested_test | | ||
| nested_test = test.(UnaryExprNode).getOperand() and | ||
| clears_taint(final_test, tainted, nested_test, sense.booleanNot()) | ||
| clears_taint(tainted, nested_test, sense.booleanNot()) | ||
| ) | ||
| } |
There was a problem hiding this comment.
Looking over this code again, I'm so confused about final_test and what it's supposed to do. Thanks for fixing this up 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not find an easy way to avoid the cartesian product in #2700, so I have simply disabled the code responsible for it.