JS: Handle 'export * as ns' #2782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-schaefer
previously approved these changes
Feb 6, 2020
max-schaefer
previously approved these changes
Feb 7, 2020
erik-krogh
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
The changes in the expected output was hard to read, so I reordered the tests such that the diff in the expected output became more readable: https://github.com/Semmle/ql/compare/master...erik-krogh:js/export-as-ns?expand=1
There are a few changes in the expected output for the existing test files, but for all of those it looks like the new output is correct.
So LGTM.
max-schaefer
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds out support for export declarations of the form:
We already parse and extract these, but they were not mentioned in our documentation and not handled by the type inference.
The proposal is at stage 4 and will be part of ES2020 (I think) and TypeScript 3.8.
Commit-by-commit review recommended.