Skip to content

Python: ObjectAPI to ValueAPI: IllegalExceptionHandlerType #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 17, 2020
Merged

Python: ObjectAPI to ValueAPI: IllegalExceptionHandlerType #2978

merged 12 commits into from
Mar 17, 2020

Conversation

BekaValentine
Copy link
Contributor

This PR is part of the Exceptions modernization effort.

@BekaValentine BekaValentine requested review from RasmusWL and tausbn March 4, 2020 15:53
@BekaValentine BekaValentine marked this pull request as ready for review March 4, 2020 15:53
@BekaValentine BekaValentine requested a review from a team as a code owner March 4, 2020 15:53
tausbn
tausbn requested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM.

@tausbn tausbn self-assigned this Mar 5, 2020
@BekaValentine BekaValentine requested a review from tausbn March 9, 2020 18:47
@BekaValentine BekaValentine mentioned this pull request Mar 9, 2020
Merged
@RasmusWL RasmusWL removed their request for review March 10, 2020 09:53
tausbn
tausbn reviewed Mar 10, 2020
View reviewed changes
tausbn
tausbn requested changes Mar 16, 2020
View reviewed changes
@BekaValentine BekaValentine requested a review from tausbn March 16, 2020 23:53
tausbn
tausbn requested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last doc fix needed, otherwise ready to merge.

@BekaValentine BekaValentine requested a review from tausbn March 17, 2020 16:49
tausbn
tausbn approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tausbn tausbn merged commit ca26fee into github:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusWL RasmusWL RasmusWL left review comments

@tausbn tausbn tausbn approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BekaValentine @RasmusWL @tausbn