Skip to content

Conversation

BekaValentine
Copy link
Contributor

This PR is part of the Exceptions modernization effort.

@BekaValentine BekaValentine marked this pull request as ready for review March 9, 2020 23:09
@BekaValentine BekaValentine requested a review from a team as a code owner March 9, 2020 23:09
@BekaValentine BekaValentine requested review from tausbn and removed request for a team March 9, 2020 23:09
@BekaValentine
Copy link
Contributor Author

BekaValentine commented Mar 9, 2020

There's gonna be a bunch of conflicts from #2978 for this, so I'd suggest we wait until that one goes through then I can deal with them cleanly hopefully. I only just realized this now, looking at 2978. :\

Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks okay, but it'll probably need to have master merged in once the other PR is merged.

Oh, and autoformatting, of course. 🙂

Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@tausbn tausbn merged commit 46567a5 into github:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants