C++: Fix mismatching new/free FP in template code. #3050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmarsh2
reviewed
Mar 11, 2020
Comment on lines
+1
to
+2
| | test2.cpp:19:3:19:6 | call to free | There is a new/free mismatch between this free and the corresponding $@. | test2.cpp:18:12:18:18 | new | new | | ||
| | test2.cpp:26:3:26:6 | call to free | There is a new/free mismatch between this free and the corresponding $@. | test2.cpp:25:7:25:13 | new | new | |
There was a problem hiding this comment.
I'm not sure why these locations moved slightly - did you rebuild the extractor between test runs?
There was a problem hiding this comment.
I can't explain that. I'll re-trigger the CI and merge if it's successful.
There was a problem hiding this comment.
I'm unlikely to have rebuilt the extractor, but it's likely I generated the first set of results, then tweaked the test code slightly and forgot to re-run the tests until the next commit. (and if the tests passed on here I'm not worried)
jbj
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3028.