Skip to content

Add execve to CommandExecution #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2020
Merged

Add execve to CommandExecution #3067

merged 1 commit into from
Mar 16, 2020

Conversation

theopolis
Copy link
Contributor

Not sure why this was left out initially, perhaps there is something I am overlooking? I think posix_spawn could be added for more coverage too. But it has a slightly different argument pattern than exists already, nevertheless easy to implement.

@theopolis theopolis requested a review from a team as a code owner March 16, 2020 00:37
@theopolis
Copy link
Contributor Author

I think posix_spawn could be added for more coverage too. But it has a slightly different argument pattern than exists already, nevertheless easy to implement.

Nevermind, I see getTarget().getName().matches("\\_spawn%")

@jbj jbj added the C++ label Mar 16, 2020
jbj
jbj approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. LGTM!

@jbj jbj merged commit 5b20133 into github:master Mar 16, 2020
@jbj
Copy link
Contributor

jbj commented Mar 16, 2020

The change is now merged and should get deployed to lgtm.com in about two weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theopolis @jbj