Python: Handle fabric.api.execute in command injection #3563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tausbn
requested changes
Jun 3, 2020
|
... |
tausbn
approved these changes
Jun 4, 2020
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Sep 8, 2020
I looked through PRs between rc/1.24 and rc/1.25 and added missing change notes for: - github#3314 - github#3302 - github#3212 - github#3453 - github#3407 - github#3563 ``` git log --grep="Merge pull request" --format=oneline rc/1.24..rc/1.25 -- python/ ```
luchua-bc
pushed a commit
to luchua-bc/ql
that referenced
this pull request
Oct 16, 2020
I looked through PRs between rc/1.24 and rc/1.25 and added missing change notes for: - github#3314 - github#3302 - github#3212 - github#3453 - github#3407 - github#3563 ``` git log --grep="Merge pull request" --format=oneline rc/1.24..rc/1.25 -- python/ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/codeql-python-team/issues/53
Closing #3164 which was my initial attempt at figuring out how to do this. In this PR I made use of a
DataFlowExtension, which seems like a better (and more modular) way of implementing this, than changingisAdditionalFlowStepof the configuration.. at least this approach made it very simple to test my changes 👍.