Skip to content

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Sep 8, 2020

I looked through PRs between rc/1.24 and rc/1.25 and added missing change notes for:

git log --grep="Merge pull request" --format=oneline rc/1.24..rc/1.25 -- python/

I'm guessing this should be against rc/1.25 branch, so it will have correct information. Once we do a mergeback from rc/1.25 to main, all should be good again.

I looked through PRs between rc/1.24 and rc/1.25 and added missing change notes for:

- github#3314
- github#3302
- github#3212
- github#3453
- github#3407
- github#3563

```
git log --grep="Merge pull request" --format=oneline rc/1.24..rc/1.25 -- python/
```
@RasmusWL RasmusWL requested a review from a team September 8, 2020 12:32
@RasmusWL RasmusWL changed the title Python: Add missing change notes Python: Add missing 1.25 change notes Sep 8, 2020
@RasmusWL RasmusWL added this to the 1.25 milestone Sep 8, 2020
Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @RasmusWL

RasmusWL and others added 2 commits September 9, 2020 10:34
backporting fixes from `@sj`
Co-authored-by: Rasmus Wriedt Larsen <rasmuswl@github.com>
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@RasmusWL
Copy link
Member Author

self merging without bot since Checks (GitHub Actions) is stuck in Pending — Triggered Actions workflow Checks (GitHub Actions)

@RasmusWL RasmusWL merged commit 637ea4a into github:rc/1.25 Sep 14, 2020
@RasmusWL RasmusWL deleted the python-missing-1.25-change-notes branch September 14, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants