C#: Split 'Context' class between CIL and source extraction #5189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
force-pushed
the
feature/refactor-3
branch
from
f33968b to
0d0e3d4
Compare
hvitved
requested changes
Feb 24, 2021
tamasvajk
force-pushed
the
feature/refactor-3
branch
from
a557fb1 to
4711856
Compare
|
@hvitved I rebased this PR, and fixed your finding. |
hvitved
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the third in multiple steps to remove nullability warnings.
It's based on #5144.This PR splits theContextclass to CIL and C# specific bits, and as a result previous nullability warnings are gone now. Also, the interfaceICachedEntityFactorywas converted to a classCachedEntityFactory. This allowed me to introduce a C# specific derivedCachedEntityFactorytoo, which uses the C# specificContextclass.Additionally, the CIL
Contextclass which previously held a reference to the overallContextinstance is now extending the base context instead.Diff job