C#: Enable nullability in Extraction.CSharp #5197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
commented
Feb 17, 2021
csharp/extractor/Semmle.Extraction.CSharp/Entities/CommentLine.cs
Outdated
Show resolved
Hide resolved
tamasvajk
force-pushed
the
feature/refactor-4
branch
from
eb7d46c to
2494324
Compare
tamasvajk
changed the title
Closed
tamasvajk
force-pushed
the
feature/refactor-4
branch
3 times, most recently
from
89fca5d to
ff858b5
Compare
tamasvajk
force-pushed
the
feature/refactor-4
branch
from
ff858b5 to
bd2b3e7
Compare
hvitved
reviewed
Mar 5, 2021
csharp/extractor/Semmle.Extraction.CSharp/Entities/CachedEntity.cs
Outdated
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction.CSharp/Entities/CommentLine.cs
Outdated
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction.CSharp/Extractor/NonStandaloneAnalyser.cs
Outdated
Show resolved
Hide resolved
| }); | ||
| } | ||
|
|
||
| private static ExitCode AnalyseNonStandalone( |
There was a problem hiding this comment.
Should this be in NonStandaloneExtractor.cs?
There was a problem hiding this comment.
I didn't want to change even more things. I think the best would be to get rid of the public static class Extractor altogether and move its bits maybe to StandaloneAnalyser and TracingAnalyser.
| return analyser.TotalErrors == 0 ? ExitCode.Ok : ExitCode.Errors; | ||
| } | ||
|
|
||
| private static void AnalyseStandalone( |
There was a problem hiding this comment.
Should this be in StandaloneExtractor.cs?
…ase CachedSymbol entity
hvitved
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the fourth in multiple steps to enable nullability analysis and remove nullability warnings. It's based on #5189. This PR enables nullability analysis on the Extraction.CSharp project. I added some
#nullable disable warningsdirectives where I couldn't get around some warnings. The biggest such section is in theAnalyser.cs, where we have a two phase initialization with theInitializeStandalone/EndInitialize, and therefore we have a lot of nullable fields. I think it's not worth the effort to try to fix these. (It seems quite cumbersome to do it without changing our log messages, which might be considered a breaking change.)The last commit is independent of nullability analysis. It combines the standalone and normal analysis into a single method. However, it needs quite a few
Func/Actionparameters, so in the end it didn't help too much with readability. Nevertheless, I think it would make sense to combine these two paths.Differences job Differences jobDifferences job