Java: Split literals tests #6613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2021
|
Test splitting part of this lgtm |
|
Marked as draft until the dependent pull request is merged. |
This allows changing individual tests in the future without having to adjust the expected output of all other tests.
Marcono1234
force-pushed
the
marcono1234/literals-test-split
branch
from
fec9676 to
e3fed55
Compare
|
Have rebased the changes onto |
aschackmull
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6612
Splits the literals test to have separate Java test classes. This simplifies future changes for a single literal type without having to adjust the expected output of all literal tests.