Skip to content

Java: Add StringLiteral.isTextBlock(). #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2021
Merged

Java: Add StringLiteral.isTextBlock(). #6749

merged 1 commit into from
Sep 27, 2021
+3 −0

Conversation

aschackmull
Copy link
Contributor

Fixes #6619

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Sep 24, 2021
@aschackmull aschackmull requested a review from a team as a code owner September 24, 2021 11:12
@github-actions github-actions bot added the Java label Sep 24, 2021
@Marcono1234
Copy link
Contributor

Do you want to extend the documentation of StringLiteral as well, or do you want to wait until fec9676 of #6613 (hopefully) adds that?

@aschackmull
Copy link
Contributor Author

Do you want to extend the documentation of StringLiteral as well, or do you want to wait until fec9676 of #6613 (hopefully) adds that?

fec9676 looks good to me, so might as well just use that (thanks!).

atorralba
atorralba approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aschackmull aschackmull merged commit 92ffd8c into github:main Sep 27, 2021
@aschackmull aschackmull deleted the java/istextblock branch September 27, 2021 08:54
@Marcono1234 Marcono1234 mentioned this pull request Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@atorralba atorralba atorralba approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java: Add CodeQL class (or predicate) for Text Blocks
3 participants
@aschackmull @Marcono1234 @atorralba