-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Java and JS: Add/adapt tests for literals with an unpaired surrogate character #6653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java and JS: Add/adapt tests for literals with an unpaired surrogate character #6653
Conversation
@github/codeql-javascript this change (extracting invalid surrogates as Do you want to accept the new FPs or find a way to fix them? Python's version of ReDoS had the same tests but they didn't work; it does produce these FPs once the test is fixed: #6665 |
c846398
to
963f684
Compare
I want to fix them. For now it handles both how surrogates look with the old/new databases. |
@erik-krogh accidental inclusion of |
4b615e9
to
76de6d1
Compare
LGTM, will push the semmle-code pointer bump to this branch tip |
6008edd
to
3e3c97b
Compare
…rrogates These were already misinterpreted, but the ReDoS code ignored them as they previously appeared to be `?` characters.
3e3c97b
to
abdd3a5
Compare
Requires semmle-code PR to pass