Skip to content

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Sep 10, 2021

This actually does result in an FP, but this was previously hidden by non-interpretation of '\u' escapes within a raw string.

This actually does result in an FP, but this was previously hidden by non-interpretation of '\u' escapes within a raw string.
@smowton
Copy link
Contributor Author

smowton commented Sep 10, 2021

I note by the way JS has an exclusion in its regex library to recognise when substitution has happened (? or now U+FFFD in the string rep, unicode escape sequence in the source rep), which could be productive to include in Python to prevent these FPs: see @erik-krogh's fix at #6653

Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yoff yoff merged commit d0563c8 into github:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants