Java: Remove duplicate classes modeling Object.clone #6673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
force-pushed
the
marcono1234/clone-method-models
branch
from
10175bb to
d117593
Compare
Marcono1234
commented
Sep 12, 2021
| from MethodAccess ma, Method m | ||
| where | ||
| m = ma.getMethod() and | ||
| m instanceof CloneMethod and |
There was a problem hiding this comment.
This might a behavior change because previously it would only consider calls to methods directly overriding Object.clone, while now it considers transitive overrides as well.
However the way the query description is written suggests that this is desired.
aschackmull
approved these changes
Sep 13, 2021
aschackmull
added
the
no-change-note-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuses the existing
CloneMethodclass for two queries which had their own CodeQL class for this method.