Skip to content

Java: Remove duplicate classes modeling Object.clone #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Java: Remove duplicate classes modeling Object.clone #6673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions java/ql/src/Advisory/Java Objects/AvoidCloneMethodAccess.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,10 @@

import java

class ObjectCloneMethod extends Method {
ObjectCloneMethod() {
this.getDeclaringType() instanceof TypeObject and
this.getName() = "clone" and
this.hasNoParameters()
}
}

from MethodAccess ma, ObjectCloneMethod clone
where ma.getMethod().overrides(clone)
from MethodAccess ma, Method m
where
m = ma.getMethod() and
m instanceof CloneMethod and
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might a behavior change because previously it would only consider calls to methods directly overriding Object.clone, while now it considers transitive overrides as well.
However the way the query description is written suggests that this is desired.

// But ignore direct calls to Object.clone
not m.getDeclaringType() instanceof TypeObject
select ma, "Invoking a method that overrides clone() should be avoided."
9 changes: 3 additions & 6 deletions java/ql/src/Advisory/Java Objects/AvoidCloneOverride.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,13 @@

import java

class ObjectCloneMethod extends Method {
ObjectCloneMethod() {
this.getDeclaringType() instanceof TypeObject and
this.getName() = "clone" and
this.hasNoParameters()
}
class ObjectCloneMethod extends CloneMethod {
ObjectCloneMethod() { this.getDeclaringType() instanceof TypeObject }
}

from Method m, ObjectCloneMethod clone
where
m.fromSource() and
// Only consider direct overrides of Object.clone
m.overrides(clone)
select m, "Overriding the Object.clone() method should be avoided."