Skip to content

Ruby: More Rails modeling #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 27, 2022
Merged

Ruby: More Rails modeling #9574

merged 6 commits into from
Jun 27, 2022

Conversation

hmac
Copy link
Contributor

@hmac hmac commented Jun 16, 2022 •
edited
Loading

  • Recognise ActionCable::Connection::TaggedLoggerProxy as a logger
  • Recognise File.atomic_write (a core extension from ActiveSupport) as a file write access
  • Recognise redirect_back and redirect_back_or_to as URL redirects
  • Recognise various methods in Rails::Generators::Actions as command executions

@github-actions github-actions bot added the Ruby label Jun 16, 2022
@hmac hmac force-pushed the hmac/action-cable-logger branch from 842f6b6 to 18d4415 Compare June 16, 2022 03:57
hmac added 6 commits June 20, 2022 13:36
@hmac
Remove duplicate import
4ecd595
@hmac
Ruby: Recognise ActionCable logger class
0ce14fc
@hmac
Ruby: Recognise File.atomic_write as a file writer
a298f5e 
This method is an ActiveSupport extension, but there's no harm in
recognising it universally as any identically-named method is likely to
also be a file writer.
@hmac
Ruby: Model redirect_back and redirect_back_or_to
7dfab37 
These are ActionController methods that redirect to the HTTP Referer,
falling back to the given location if there is no Referer.
@hmac
Ruby: Model ActiveRecord::Relation#touch_all
20ff4c4
@hmac
Ruby: Model methods in Rails::Generators::Actions
e1dcc20 
These methods are sinks for command injection.
@hmac hmac force-pushed the hmac/action-cable-logger branch from e15afc3 to e1dcc20 Compare June 20, 2022 01:36
@hmac hmac marked this pull request as ready for review June 21, 2022 22:55
@hmac hmac requested a review from a team as a code owner June 21, 2022 22:55
@hmac hmac added the no-change-note-required This PR does not need a change note label Jun 21, 2022
nickrolfe
nickrolfe approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@nickrolfe nickrolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@hmac hmac merged commit 101111b into github:main Jun 27, 2022
@hmac hmac deleted the hmac/action-cable-logger branch June 27, 2022 07:56
@asgerf asgerf mentioned this pull request Jun 27, 2022
Merged
@nickrolfe nickrolfe mentioned this pull request Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrolfe nickrolfe nickrolfe approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmac @nickrolfe