Ruby: fix defining every dataflow node as a command execution sink #9797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calumgrant
reviewed
Jul 11, 2022
|
6632dfa includes a similar fix for |
hmac
previously approved these changes
Jul 11, 2022
Co-authored-by: intrigus-lgtm <60750685+intrigus-lgtm@users.noreply.github.com>
calumgrant
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any database where there is at least one call to
execute_command,rake,rails_command, orgitfromRails::Generations::Actions, we accidentally defined every dataflow node in the database as a system command execution sink.Originally introduced in #9574, but presumably not spotted by the DCA run because none of our DCA projects call one of those methods.