remove hyphen in label to match UI #3216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses #3215
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
janiceilene
reviewed
Jan 28, 2021
| {% endnote %} | ||
|
|
||
| You can set up required status checks to either be "loose" or "strict." The type of required status check you choose determines whether your branch is required to be up-to-date with the base branch before merging. | ||
|
|
Contributor
There was a problem hiding this comment.
Thanks so much for opening an issue and PR for this fix @brian-armory! I can't comment on the line above ☝️ but there's one more "up-to-date" on line 85. Could you update that one, as well, please? Let me know when you do and we'll get this merged in ⚡
janiceilene
added
content
janiceilene
approved these changes
Feb 1, 2021
Contributor
janiceilene
left a comment
janiceilene
left a comment
There was a problem hiding this comment.
Thanks for updating that last one! This looks great 🥳 I'll update the branch and merge once tests are passing 🍏
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The docs don't match the UI for this feature. The UI doesn't use - for the label Require branches to be up to date... (#3215)
What's being changed:
Removes the
-in the references to the UI labelCheck off the following: