Skip to content

Document GitHub serverside limit on URL length #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janiceilene merged 5 commits into from
Apr 22, 2021
Merged

Document GitHub serverside limit on URL length #4537

janiceilene merged 5 commits into from
Apr 22, 2021

Conversation

@gukoff
Copy link
Contributor

@gukoff gukoff commented Mar 15, 2021 •
edited
Loading

example of a long URL

Why:

Closes #5136

What's being changed:

Add a note about the URL length limit.

Check off the following:

@gukoff
Document GitHub serverside limit on URL length
904a4e5 
[example of a long URL](https://github.com/azure/azure-iot-cli-extension/issues/new?template=Bug_report.md&body=%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A%0A%23%23%23+%2A%2AThis+is+autogenerated.%0A123123213)
@welcome
Copy link

welcome bot commented Mar 15, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

janiceilene commented Mar 16, 2021

Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2021

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Mar 29, 2021
Abhishek577270
Abhishek577270 approved these changes Mar 29, 2021
View reviewed changes
Copy link

@Abhishek577270 Abhishek577270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got gold money cash

@guaxy94

This comment has been minimized.

Sign in to view
@gukoff
Copy link
Contributor Author

gukoff commented Mar 30, 2021

Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

OK, will do

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Mar 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Apr 6, 2021
Abhishek577270
Abhishek577270 previously approved these changes Apr 7, 2021
View reviewed changes
Abhishek577270
Abhishek577270 reviewed Apr 7, 2021
View reviewed changes
Copy link

@Abhishek577270 Abhishek577270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My love

@gukoff
Copy link
Contributor Author

gukoff commented Apr 7, 2021

Duplicated info from here to #5136
Added here a link to this new issue.
Don't see what else to change in the template, it's a very small change.

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Apr 7, 2021
@janiceilene
Copy link
Contributor

janiceilene commented Apr 8, 2021

Thanks for filling out the PR template and opening an issue @gukoff! I'll get this up for review ⚡ Can you clarify how you know the serverside limit is 8191 bytes URL?

@janiceilene janiceilene added core waiting for review Issue/PR is waiting for a writer's review labels Apr 8, 2021
@gukoff
Copy link
Contributor Author

gukoff commented Apr 9, 2021

Can you clarify how you know the serverside limit is 8191 bytes URL?

Sure, see the link "example of a long URL" in the description.

@lee-dohm
Update content/github/managing-your-work-on-github/about-automation-f…
76a04a6 
…or-issues-and-pull-requests-with-query-parameters.md


Simplifying language and bringing into line with our standards
@lee-dohm lee-dohm dismissed stale reviews from ghost and Abhishek577270 via 76a04a6 April 22, 2021 14:55
lee-dohm
lee-dohm approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@lee-dohm lee-dohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@janiceilene janiceilene merged commit 9d6cf34 into github:main Apr 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Abhishek577270 Abhishek577270 Abhishek577270 left review comments

@lee-dohm lee-dohm lee-dohm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document GitHub serverside limit on URL length

5 participants

@gukoff @janiceilene @guaxy94 @lee-dohm @Abhishek577270