Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it more clear that you need to setup your runners #21211

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Make it more clear that you need to setup your runners #21211

merged 5 commits into from
Oct 11, 2022

Conversation

rajbos
Copy link
Contributor

@rajbos rajbos commented Oct 8, 2022

Why:

Make it more clear that you need to setup your runners by indicating the reason why this is needed. Since we already had runners, I had expected this would 'just work', so I read over this. This change makes it more specific.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
admin/configuration/configuring-github-connect/enabling-dependabot-for-your-enterprise.md ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

👋 @rajbos Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review dependabot Content related to Dependabot and removed triage Do not begin working on this issue until triaged by the team labels Oct 10, 2022
lecoursen
lecoursen previously approved these changes Oct 11, 2022
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajbos, I agree this is helpful to clarify! I'm going to apply a small suggestion and then merge! ⚡

@lecoursen lecoursen added the enterprise Content relating to GitHub Enterprise label Oct 11, 2022
@lecoursen lecoursen added the ready to merge This pull request is ready to merge label Oct 11, 2022
@docubot docubot added this to Triage in Docs open source board Oct 11, 2022
@lecoursen lecoursen merged commit b8fa4b4 into github:main Oct 11, 2022
Docs open source board automation moved this from Triage to Done Oct 11, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@cmwilson21 cmwilson21 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team dependabot Content related to Dependabot enterprise Content relating to GitHub Enterprise hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants