Skip to content

Update deploying-to-azure-static-web-app.md #28674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

blueboxes
Copy link
Contributor

Updated to use the newly released v1 actions (as per template in azure) and set permissions to allow a comment to be written to the PR.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Updated to use the newly released v1 actions (as per template in azure) and set permissions to allow a comment to be written to the PR.
@welcome
Copy link

welcome bot commented Sep 30, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/deploying-to-your-cloud-provider/deploying-to-azure/deploying-to-azure-static-web-app.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@blueboxes Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 2, 2023
@SiaraMist
Copy link
Contributor

Hi @blueboxes, thank you so much for submitting this PR! ✨ I definitely understand why you are updating this workflow to use v1 instead of pinning to a commit SHA. However, per our style guide, for third party actions we always pin to a commit SHA to comply with our security recommendations. If it helps at all, we include a note at the top of workflows that do this to help explain why. I'm going to close out this PR, and if you want to further contribute to our docs, please check out our help wanted board, where we have open issues to improve our docs. Thank you again!

@SiaraMist SiaraMist closed this Oct 2, 2023
@SiaraMist SiaraMist reopened this Oct 2, 2023
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 2, 2023
…ploying-to-azure/deploying-to-azure-static-web-app.md
…ploying-to-azure/deploying-to-azure-static-web-app.md
Copy link
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw the permissions you added, so I updated the PR so I can accept that update to the example! Apologies for not catching that earlier. Thank you for your help improving the docs! I'll go ahead and get this merged.

@SiaraMist SiaraMist enabled auto-merge October 2, 2023 19:28
@SiaraMist SiaraMist added this pull request to the merge queue Oct 2, 2023
Merged via the queue into github:main with commit 7487514 Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team triage Do not begin working on this issue until triaged by the team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants