Skip to content

Conversation

@janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Feb 8, 2024

[WIP] changes requested see #31686

Why:

The sentence reads somewhat puzzling until you realize those are "token" roles. Quoting them, and making them capitalized to distinguish it's not a ordinary word but a "term" helps readability.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Occurrences of maintain and write roles in rulesets reusables changed to "Maintain" and "Write".

Older docs use emphasis Write and Maintain but that has since been used solely for CTA/UI elements to activate, so while visually better looking a more basic quoting + capitalization was chosen.

Reusable usage:

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 8, 2024
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 8, 2024
@nguyenalex836
Copy link
Contributor

@janbrasna Thanks so much for opening a PR! I'll get this triaged for review ✨

@janbrasna
Copy link
Contributor Author

@janbrasna janbrasna marked this pull request as draft February 25, 2024 18:41
@janbrasna janbrasna closed this Feb 29, 2024
@janbrasna janbrasna deleted the patch-1 branch February 29, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants