Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/archives/tests/deprecated-enterprise-versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,7 @@ describe('recently deprecated redirects', () => {
})

describe('deprecation banner', () => {
// The deprecation banner is temporarily hidden for supported versions
test.skip('renders a deprecation warning banner on oldest supported Enterprise version', async () => {
test('renders a deprecation warning banner on oldest supported Enterprise version', async () => {
const { $ } = await getDOM(`/en/enterprise/${enterpriseServerReleases.oldestSupported}`)
expect($('[data-testid=deprecation-banner]').length).toBe(1)
})
Expand All @@ -154,8 +153,7 @@ describe('deprecation banner', () => {
expect($('[data-testid=deprecation-banner] b').text().endsWith('discontinued on .')).toBe(false)
})

// The deprecation banner is temporarily hidden for supported versions
test.skip('deprecation warning banner includes the right text depending on the date', async () => {
test('deprecation warning banner includes the right text depending on the date', async () => {
const { $ } = await getDOM(`/en/enterprise/${enterpriseServerReleases.oldestSupported}`)
const expectedString = enterpriseServerReleases.isOldestReleaseDeprecated
? 'was discontinued'
Expand Down
12 changes: 6 additions & 6 deletions src/ghes-releases/lib/enterprise-dates.json
Original file line number Diff line number Diff line change
Expand Up @@ -229,31 +229,31 @@
},
"3.14": {
"releaseDate": "2024-08-06",
"deprecationDate": "2025-08-27",
"deprecationDate": "2026-03-17",
"releaseCandidateDate": "2024-08-06",
"generalAvailabilityDate": "2024-08-27"
},
"3.15": {
"releaseDate": "2024-11-12",
"deprecationDate": "2025-12-19",
"deprecationDate": "2026-03-17",
"releaseCandidateDate": "2024-11-12",
"generalAvailabilityDate": "2024-12-03"
},
"3.16": {
"releaseDate": "2025-02-25",
"deprecationDate": "2026-03-11",
"deprecationDate": "2026-06-02",
"releaseCandidateDate": "2025-02-25",
"generalAvailabilityDate": "2025-03-11"
},
"3.17": {
"releaseDate": "2025-05-13",
"deprecationDate": "2026-06-03",
"deprecationDate": "2026-08-25",
"releaseCandidateDate": "2025-05-13",
"generalAvailabilityDate": "2025-06-03"
},
"3.18": {
"releaseDate": "2025-08-05",
"deprecationDate": "2026-08-26",
"deprecationDate": "2026-08-25",
"releaseCandidateDate": "2025-08-05",
"generalAvailabilityDate": "2025-08-26"
},
Expand Down Expand Up @@ -287,4 +287,4 @@
"releaseCandidateDate": "2026-11-10",
"generalAvailabilityDate": "2026-12-08"
}
}
}
18 changes: 18 additions & 0 deletions src/graphql/data/fpt/changelog.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,22 @@
[
{
"schemaChanges": [
{
"title": "The GraphQL schema includes these changes:",
"changes": []
}
],
"previewChanges": [],
"upcomingChanges": [
{
"title": "The following changes will be made to the schema:",
"changes": [
"<p>On member <code>SearchType.ISSUE_ADVANCED</code>:<code>ISSUE_ADVANCED</code> will be removed. <strong>Effective 2025-11-04</strong>.</p>"
]
}
],
"date": "2025-09-05"
},
{
"schemaChanges": [
{
Expand Down
16 changes: 8 additions & 8 deletions src/graphql/data/fpt/graphql_upcoming_changes.public.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1504,14 +1504,6 @@ upcoming_changes:
date: '2025-04-01T00:00:00+00:00'
criticality: breaking
owner: github/memex
- location: SearchType.ISSUE_ADVANCED
description: '`ISSUE_ADVANCED` will be removed.'
reason:
Search for issues and pull requests will be overridden by advanced search
on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/.
date: '2025-09-04'
criticality: breaking
owner: github/issues_advanced_search
- location: Issue.stateReason.enableDuplicate
description: '`enableDuplicate` will be removed.'
reason: The state reason for duplicate issue is now returned by default.
Expand All @@ -1526,6 +1518,14 @@ upcoming_changes:
date: '2025-10-01T00:00:00+00:00'
criticality: breaking
owner: github/advisory-database
- location: SearchType.ISSUE_ADVANCED
description: '`ISSUE_ADVANCED` will be removed.'
reason:
Search for issues and pull requests will be overridden by advanced search
on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/.
date: '2025-11-04'
criticality: breaking
owner: github/issues_advanced_search
- location: NotificationThread.list
description: '`list` will be removed. Use the `optionalList` field instead.'
reason: Null values are possible for this field.
Expand Down
2 changes: 1 addition & 1 deletion src/graphql/data/fpt/schema.docs.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -55192,7 +55192,7 @@ enum SearchType {
"""
ISSUE_ADVANCED
@deprecated(
reason: "Search for issues and pull requests will be overridden by advanced search on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. Removal on 2025-09-04 UTC."
reason: "Search for issues and pull requests will be overridden by advanced search on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. Removal on 2025-11-04 UTC."
)

"""
Expand Down
20 changes: 10 additions & 10 deletions src/graphql/data/fpt/upcoming-changes.json
Original file line number Diff line number Diff line change
Expand Up @@ -8891,6 +8891,16 @@
"owner": "github/notifications"
}
],
"2025-11-04": [
{
"location": "SearchType.ISSUE_ADVANCED",
"description": "<p><code>ISSUE_ADVANCED</code> will be removed.</p>",
"reason": "<p>Search for issues and pull requests will be overridden by advanced search on November 4, 2025. You can read more about this change on <a href=\"https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/\">https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/</a>.</p>",
"date": "2025-11-04",
"criticality": "breaking",
"owner": "github/issues_advanced_search"
}
],
"2025-10-01": [
{
"location": "SecurityAdvisory.cvss",
Expand All @@ -8909,16 +8919,6 @@
"owner": "issues"
}
],
"2025-09-04": [
{
"location": "SearchType.ISSUE_ADVANCED",
"description": "<p><code>ISSUE_ADVANCED</code> will be removed.</p>",
"reason": "<p>Search for issues and pull requests will be overridden by advanced search on September 4, 2025. You can read more about this change on <a href=\"https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/\">https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/</a>.</p>",
"date": "2025-09-04",
"criticality": "breaking",
"owner": "github/issues_advanced_search"
}
],
"2025-04-01": [
{
"location": "User.viewerCanCreateProjects",
Expand Down
16 changes: 8 additions & 8 deletions src/graphql/data/ghec/graphql_upcoming_changes.public.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1504,14 +1504,6 @@ upcoming_changes:
date: '2025-04-01T00:00:00+00:00'
criticality: breaking
owner: github/memex
- location: SearchType.ISSUE_ADVANCED
description: '`ISSUE_ADVANCED` will be removed.'
reason:
Search for issues and pull requests will be overridden by advanced search
on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/.
date: '2025-09-04'
criticality: breaking
owner: github/issues_advanced_search
- location: Issue.stateReason.enableDuplicate
description: '`enableDuplicate` will be removed.'
reason: The state reason for duplicate issue is now returned by default.
Expand All @@ -1526,6 +1518,14 @@ upcoming_changes:
date: '2025-10-01T00:00:00+00:00'
criticality: breaking
owner: github/advisory-database
- location: SearchType.ISSUE_ADVANCED
description: '`ISSUE_ADVANCED` will be removed.'
reason:
Search for issues and pull requests will be overridden by advanced search
on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/.
date: '2025-11-04'
criticality: breaking
owner: github/issues_advanced_search
- location: NotificationThread.list
description: '`list` will be removed. Use the `optionalList` field instead.'
reason: Null values are possible for this field.
Expand Down
2 changes: 1 addition & 1 deletion src/graphql/data/ghec/schema.docs.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -55192,7 +55192,7 @@ enum SearchType {
"""
ISSUE_ADVANCED
@deprecated(
reason: "Search for issues and pull requests will be overridden by advanced search on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. Removal on 2025-09-04 UTC."
reason: "Search for issues and pull requests will be overridden by advanced search on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. Removal on 2025-11-04 UTC."
)

"""
Expand Down
20 changes: 10 additions & 10 deletions src/graphql/data/ghec/upcoming-changes.json
Original file line number Diff line number Diff line change
Expand Up @@ -8891,6 +8891,16 @@
"owner": "github/notifications"
}
],
"2025-11-04": [
{
"location": "SearchType.ISSUE_ADVANCED",
"description": "<p><code>ISSUE_ADVANCED</code> will be removed.</p>",
"reason": "<p>Search for issues and pull requests will be overridden by advanced search on November 4, 2025. You can read more about this change on <a href=\"https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/\">https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/</a>.</p>",
"date": "2025-11-04",
"criticality": "breaking",
"owner": "github/issues_advanced_search"
}
],
"2025-10-01": [
{
"location": "SecurityAdvisory.cvss",
Expand All @@ -8909,16 +8919,6 @@
"owner": "issues"
}
],
"2025-09-04": [
{
"location": "SearchType.ISSUE_ADVANCED",
"description": "<p><code>ISSUE_ADVANCED</code> will be removed.</p>",
"reason": "<p>Search for issues and pull requests will be overridden by advanced search on September 4, 2025. You can read more about this change on <a href=\"https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/\">https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/</a>.</p>",
"date": "2025-09-04",
"criticality": "breaking",
"owner": "github/issues_advanced_search"
}
],
"2025-04-01": [
{
"location": "User.viewerCanCreateProjects",
Expand Down
10 changes: 0 additions & 10 deletions src/versions/components/DeprecationBanner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@ import cx from 'classnames'

import styles from './DeprecationBanner.module.scss'

// GHES deprecation dates are being extended while
// performance issues are being addressed in versions >= 3.15.
// This banner should remain hidden for the supported versions (>=3.14) until
// new deprecation dates are announced.
const DEPRECATION_BANNER_EXCEPTIONS = ['3.14']

export const DeprecationBanner = () => {
const { data, enterpriseServerReleases } = useMainContext()
const { currentVersion } = useVersion()
Expand All @@ -29,10 +23,6 @@ export const DeprecationBanner = () => {
? enterpriseDeprecation.version_was_deprecated
: enterpriseDeprecation.version_will_be_deprecated

if (DEPRECATION_BANNER_EXCEPTIONS.some((version) => currentVersion.includes(version))) {
return null
}

return (
<div
data-testid="deprecation-banner"
Expand Down
Loading