Skip to content

Conversation

@TWiStErRob
Copy link
Contributor

@TWiStErRob TWiStErRob commented Sep 25, 2025

Why:

  1. The links pointing to the specific SHA and file path are outdated. The files have been moved around. See sarif 2.1.0 schema url in Schemata stopped working oasis-tcs/sarif-spec#646 for more details. Note: because the links were using specific SHA they were still working, they are just pointing to an old version. There is one actual meaningful difference (language regex is wrong).

What's being changed (if available, include any code snippets, screenshots, or gifs):

Only the pointed links changed:

  • The link SARIF specfication documentation now points to the docs, not the schema. This is the same URL to where the OASIS Standard link points.
  • The schema links using SHA has been replaced to point to the link used in the spec.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Copilot AI review requested due to automatic review settings September 25, 2025 22:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates outdated SARIF specification and schema links in the GitHub documentation. The previous links pointed to specific SHA commits and file paths that are no longer valid due to repository restructuring in the SARIF specification repository.

  • Updated SARIF specification documentation link to point to the official OASIS documentation
  • Updated SARIF schema links to use the current canonical URLs instead of outdated SHA-specific paths

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
content/code-security/codeql-cli/using-the-advanced-functionality-of-the-codeql-cli/sarif-output.md Updated SARIF specification and schema links to use current canonical URLs
content/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning.md Updated SARIF schema link to use current canonical URL

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 25, 2025
@github-actions
Copy link
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
code-security/codeql-cli/using-the-advanced-functionality-of-the-codeql-cli/sarif-output.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@TWiStErRob TWiStErRob changed the title Patch 2 Replace outdated hardcoded GitHub SHA links for SARIF schemas with HTTP links Sep 25, 2025
@Sharra-writes
Copy link
Contributor

@TWiStErRob I've confirmed the links work, and I'm going to trust the community that the content in them is correct, since you know better than I do.

@Sharra-writes Sharra-writes added this pull request to the merge queue Sep 25, 2025
Merged via the queue into github:main with commit ccbafd0 Sep 25, 2025
51 checks passed
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants