Repo sync

eslint.config.ts

@@ -96,7 +96,6 @@ export default [
       camelcase: 'off', // Many gh apis use underscores, 600+ uses
 
       // Disabled rules to review
-      '@typescript-eslint/ban-ts-comment': 'off', // 50+
       'github/array-foreach': 'off', // 250+
       'no-console': 'off', // 800+
       '@typescript-eslint/no-explicit-any': 'off', // 1000+

src/assets/scripts/validate-asset-images.ts

@@ -17,7 +17,6 @@ import path from 'path'
 import { program } from 'commander'
 import chalk from 'chalk'
 import cheerio from 'cheerio'
-// @ts-ignore see https://github.com/sindresorhus/file-type/issues/652
 import { fileTypeFromFile } from 'file-type'
 import walk from 'walk-sync'
 import isSVG from 'is-svg'

src/content-linter/lib/helpers/get-rules.ts

@@ -4,7 +4,6 @@ import { customConfig } from '@/content-linter/style/github-docs'
 import type { Rule } from '@/content-linter/types'
 
 // Import markdownlint rules - external library without TypeScript declarations
-// @ts-ignore - markdownlint doesn't provide TypeScript declarations
 import markdownlintRules from '../../../../node_modules/markdownlint/lib/rules'
 
 export const customRules: Rule[] = gitHubDocsMarkdownlint.rules

src/content-linter/lib/helpers/print-annotations.ts

@@ -8,7 +8,10 @@
 export function printAnnotationResults(
   // Using 'any' type as results structure is dynamic and comes from various linting tools with different formats
   results: any,
-  { skippableRules = [], skippableFlawProperties = [] } = {},
+  {
+    skippableRules = [],
+    skippableFlawProperties = [],
+  }: { skippableRules?: string[]; skippableFlawProperties?: string[] } = {},
 ) {
   for (const [file, flaws] of Object.entries(results)) {
     // Using 'any' type for flaws as they have varying structures depending on the linting rule

src/content-linter/lib/helpers/utils.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 import matter from '@gr2m/gray-matter'
 

src/content-linter/lib/linting-rules/code-annotation-comment-spacing.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 
 import type { RuleParams, RuleErrorCallback, MarkdownToken } from '@/content-linter/types'

src/content-linter/lib/linting-rules/code-annotations.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 
 import { getFrontmatter } from '@/content-linter/lib/helpers/utils'

src/content-linter/lib/linting-rules/ctas-schema.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import Ajv from 'ajv'
 

src/content-linter/lib/linting-rules/early-access-references.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import yaml from 'js-yaml'
 

src/content-linter/lib/linting-rules/expired-content.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError, newLineRe } from 'markdownlint-rule-helpers'
 
 import type { RuleParams, RuleErrorCallback, MarkdownToken, Rule } from '@/content-linter/types'

src/content-linter/lib/linting-rules/frontmatter-hero-image.ts

@@ -1,6 +1,5 @@
 import fs from 'fs'
 import path from 'path'
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { getFrontmatter } from '../helpers/utils'

src/content-linter/lib/linting-rules/frontmatter-hidden-docs.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import type { RuleParams, RuleErrorCallback } from '../../types'
 

src/content-linter/lib/linting-rules/frontmatter-intro-links.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { getFrontmatter } from '../helpers/utils'

src/content-linter/lib/linting-rules/frontmatter-landing-recommended.ts

@@ -1,6 +1,5 @@
 import fs from 'fs'
 import path from 'path'
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { getFrontmatter } from '../helpers/utils'

src/content-linter/lib/linting-rules/frontmatter-schema.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import { intersection } from 'lodash-es'
 

src/content-linter/lib/linting-rules/frontmatter-versions-whitespace.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import { getFrontmatter } from '@/content-linter/lib/helpers/utils'
 import type { RuleParams, RuleErrorCallback, Rule } from '@/content-linter/types'

src/content-linter/lib/linting-rules/frontmatter-video-transcripts.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import path from 'path'
 

src/content-linter/lib/linting-rules/github-owned-action-references.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError, ellipsify } from 'markdownlint-rule-helpers'
 import type { RuleParams, RuleErrorCallback } from '../../types'
 

src/content-linter/lib/linting-rules/hardcoded-data-variable.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError, ellipsify } from 'markdownlint-rule-helpers'
 import type { RuleParams, RuleErrorCallback } from '../../types'
 

src/content-linter/lib/linting-rules/header-content-requirement.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 
 import type { RuleParams, RuleErrorCallback, MarkdownToken } from '@/content-linter/types'

src/content-linter/lib/linting-rules/image-alt-text-exclude-start-words.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { forEachInlineChild, getRange } from '../helpers/utils'

src/content-linter/lib/linting-rules/image-alt-text-length.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import type { RuleParams, RuleErrorCallback } from '../../types'
 

src/content-linter/lib/linting-rules/image-no-gif.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { forEachInlineChild } from '@/content-linter/lib/helpers/utils'

src/content-linter/lib/linting-rules/index.ts

@@ -1,6 +1,4 @@
-// @ts-ignore - markdownlint-rule-search-replace doesn't provide TypeScript declarations
 import searchReplace from 'markdownlint-rule-search-replace'
-// @ts-ignore - @github/markdownlint-github doesn't provide TypeScript declarations
 import markdownlintGitHub from '@github/markdownlint-github'
 
 import { imageAltTextEndPunctuation } from '@/content-linter/lib/linting-rules/image-alt-text-end-punctuation'

src/content-linter/lib/linting-rules/internal-links-no-lang.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { filterTokens } from 'markdownlint-rule-helpers'
 
 import { addFixErrorDetail, getRange } from '../helpers/utils'

src/content-linter/lib/linting-rules/internal-links-old-version.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 
 import { getRange } from '../helpers/utils'

src/content-linter/lib/linting-rules/internal-links-slash.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { filterTokens } from 'markdownlint-rule-helpers'
 
 import { addFixErrorDetail, getRange } from '../helpers/utils'

src/content-linter/lib/linting-rules/journey-tracks-guide-path-exists.ts

@@ -1,6 +1,5 @@
 import fs from 'fs'
 import path from 'path'
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { getFrontmatter } from '../helpers/utils'

src/content-linter/lib/linting-rules/journey-tracks-liquid.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { getFrontmatter } from '../helpers/utils'

src/content-linter/lib/linting-rules/journey-tracks-unique-ids.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { getFrontmatter } from '../helpers/utils'

src/content-linter/lib/linting-rules/link-punctuation.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 import type { RuleParams, RuleErrorCallback, Rule } from '../../types'
 

src/content-linter/lib/linting-rules/link-quotation.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 import { getRange, quotePrecedesLinkOpen } from '../helpers/utils'
 import { escapeRegExp } from 'lodash-es'

src/content-linter/lib/linting-rules/liquid-data-tags.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import { TokenKind } from 'liquidjs'
 

src/content-linter/lib/linting-rules/liquid-ifversion-versions.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import {

src/content-linter/lib/linting-rules/liquid-quoted-conditional-arg.ts

@@ -1,5 +1,4 @@
 import { TokenKind } from 'liquidjs'
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { getLiquidTokens, conditionalTags, getPositionData } from '../helpers/liquid-utils'

src/content-linter/lib/linting-rules/liquid-syntax.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { getFrontmatter } from '../helpers/utils'

src/content-linter/lib/linting-rules/liquid-versioning.ts

@@ -1,6 +1,5 @@
 import semver from 'semver'
 import { TokenKind } from 'liquidjs'
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import { getRange, addFixErrorDetail } from '../helpers/utils'

src/content-linter/lib/linting-rules/outdated-release-phase-terminology.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError, ellipsify } from 'markdownlint-rule-helpers'
 
 import { getRange } from '@/content-linter/lib/helpers/utils'

src/content-linter/lib/linting-rules/rai-reusable-usage.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import { TokenKind } from 'liquidjs'
 import path from 'path'

src/content-linter/lib/linting-rules/table-column-integrity.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 import { getRange } from '../helpers/utils'
 import frontmatter from '@/frame/lib/read-frontmatter'

src/content-linter/lib/linting-rules/table-liquid-versioning.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError } from 'markdownlint-rule-helpers'
 
 import type { RuleParams, RuleErrorCallback, Rule } from '@/content-linter/types'

src/content-linter/lib/linting-rules/third-party-action-pinning.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 import yaml from 'js-yaml'
 

src/content-linter/lib/linting-rules/third-party-actions-reusable.ts

@@ -1,4 +1,3 @@
-// @ts-ignore - markdownlint-rule-helpers doesn't provide TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 
 import type { RuleParams, RuleErrorCallback, MarkdownToken } from '@/content-linter/types'

src/content-linter/lib/linting-rules/yaml-scheduled-jobs.ts

@@ -1,5 +1,4 @@
 import yaml from 'js-yaml'
-// @ts-ignore - markdownlint-rule-helpers doesn't have TypeScript declarations
 import { addError, filterTokens } from 'markdownlint-rule-helpers'
 
 import { liquid } from '@/content-render/index'