Skip to content

Add missing validations showcase to checkboxes examples #41338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing validations showcase to checkboxes examples #41338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ For example, the following form definition includes four form elements: a text a
options:
- label: I agree to follow this project's [Code of Conduct](link/to/coc)
required: true
validations:
required: true
Comment on lines +53 to +54
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkbox already has required: true at the item level (line 52). Adding a top-level validations.required may be redundant or confusing. Clarify whether both are needed or if one should be removed to avoid duplication.

Suggested change
validations:
required: true

Copilot uses AI. Check for mistakes.
- type: markdown
attributes:
value: "Thanks for completing our form!"
Expand Down Expand Up @@ -266,6 +268,8 @@ body:
- label: macOS
- label: Windows
- label: Linux
validations:
required: true
```

## Further reading
Expand Down
Loading