Potential fixes for 2 code scanning alerts #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fixes for 2 code scanning alerts from the Copilot AutoFix: Missing Permissions in Workflows security campaign:
https://github.com/github/file-attachment-element/security/code-scanning/2
To fix this problem, we should add a
permissionsblock with least privilege settings. The recommended minimal starting point iscontents: read, which allows the workflow to read repository contents (necessary for actions such ascheckout). Since this workflow publishes to npm (not interacting with GitHub issues, pull requests, or other entities) and makes no apparent changes to the repository itself,contents: readis likely sufficient. Thepermissionsblock should be added at the job level (underpublish-npm:) for minimal scope. The change requires modifying the YAML specification in.github/workflows/publish.yml.https://github.com/github/file-attachment-element/security/code-scanning/1
To fix the issue, add a
permissions:block specifying limitedreadaccess to thecontentsscope. This block should be placed either at the root level of the workflow, directly below thenameandonentries, or within the relevant job. Given that all jobs in this workflow appear to only read contents (e.g., checkout, build, test) and no write actions (such as publishing releases or updating anything on GitHub itself) are performed, restricting permissions tocontents: readis appropriate. Modify the.github/workflows/nodejs.ymlfile to add the following block beforejobs::This change restricts the GITHUB_TOKEN permissions in the workflow to only what is necessary for the steps as shown.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.