[Coverage Report] Test Coverage Report — 2026-06-20 #5327
Replies: 3 comments
-
|
🔮 The ancient spirits stir, and this smoke-test agent has passed through the archive. The omens are green; may the discussion remember this visit. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Beta Was this translation helpful? Give feedback.
-
|
🔮 The ancient spirits stir... Smoke test agent was here, and the omen reads clean. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Beta Was this translation helpful? Give feedback.
-
|
This discussion was automatically closed because it expired on 2026-06-27T15:51:18.569Z.
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Overall Coverage
Security-Critical File Coverage
host-iptables.ts(re-export)host-iptables-rules.tshost-iptables-shared.tshost-iptables-cleanup.tssquid-config.ts(re-export)domain-patterns.tsdomain-matchers.tsdomain-validation.tscli.tsdocker-manager.ts(re-export)Top Branch Coverage Gaps
Files sorted by branch coverage ascending (statement coverage ≥ 80% for all):
services/agent-volumes/etc-mounts.tsservices/agent-volumes/system-mounts.tsservices/doh-proxy-service.tslogs/log-streamer.tsworkdir-setup.tssquid-log-reader.tspid-tracker.tsconfig-writer.tsNotable Findings
Excellent overall health. Statement coverage is 97.61% and function coverage is 98.85%, both well above the 80% quality bar. All five named security-critical modules (
host-iptables-*,squid-config,domain-patterns,domain-matchers,docker-manager) meet or exceed 95% statement coverage.etc-mounts.tsis the most significant security gap. At 67.85% branch coverage (9 of 28 branches untested), this module controls which/etcfiles are bind-mounted into the agent container — including the logic that deliberately excludes/etc/shadowand unwhitelisted paths. Untested branches here carry the highest risk of a security regression slipping in undetected.system-mounts.tsanddoh-proxy-service.tshave 75% branch coverage.system-mounts.tsgoverns kernel VFS passthrough (the special-casing of/dev,/sys,/procduring DinD path translation). Its 3 uncovered branches likely include the path where prefix translation is skipped for those special paths — important for correctness under ARC/DinD deployments.Minor gaps in
domain-patterns.tsandcli.ts. Both files are small (25 and 7 statements respectively) but are explicitly listed as security-critical.domain-patterns.tshas 2 uncovered branches (89.47%) andcli.tshas 1 of 2 branches uncovered (50%). These are quick wins that would achieve 100% branch coverage on named security-critical paths.Recommendations
🔴 High —
services/agent-volumes/etc-mounts.tsbranch coverage (67.85% → 95%+)Add unit tests covering the 9 untested branches in
etc-mounts.ts. Focus on:/etc/shadowand other sensitive files from the bind-mount list/etcfile is missing on the hostThis is the only file in the codebase where uncovered branches sit directly on a security exclusion decision.
🟡 Medium —
system-mounts.tsVFS passthrough andlogs/log-streamer.tserror pathssystem-mounts.ts(75% branch): Write tests that exercise the kernel VFS exclusion logic with and without--docker-host-path-prefix. A regression here can silently break ARC runners or expose/procentries that should be hidden.logs/log-streamer.ts(77.77% branch): Cover the 8 untested branches — likely stream-close, error-emission, and backpressure paths. Log streaming failures are silent and can cause audit gaps in production.🟢 Low — Close named security-critical branch gaps (
domain-patterns.ts,cli.ts)Both files need ≤ 2 additional branch-covering test cases each:
domain-patterns.ts: Add a test for the 2 uncovered branch conditions in the domain normalization/matching logic (e.g., input that triggers the alternate branch in the pattern check).cli.ts: Cover the untested branch in the entry-point error-handling or environment check at startup.Resolving these brings all five explicitly security-critical files to ≥ 95% branch coverage.
Beta Was this translation helpful? Give feedback.
All reactions