[Coverage Report] Test Coverage Report — 2026-06-25 #5550
Replies: 1 comment
-
|
🔮 The ancient spirits stir: the smoke test agent was here, and the omens point toward green skies. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Overall Coverage
Test suite: 156 test files · 183 source files instrumented
Security-Critical Files
host-iptables-rules.tshost-iptables-chain.tshost-iptables-cleanup.tshost-iptables-network.tssquid/access-rules.tssquid/acl-generator.tssquid/config-sections.tssquid/domain-acl.tssquid/config-generator.tsdomain-patterns.tsdocker-manager.tscli.ts(entry point)Coverage Gaps by File
All files with branch coverage < 90%
cli.tsconfig-writer.tssquid/config-sections.tsssl-bump.tssquid/ssl-bump.tshost-iptables-chain.tsdomain-patterns.tscompose-generator.tsapi-proxy-config-domains.tsNotable Findings
squid/config-sections.tshas 5 uncovered branches (82.75%) — this file controls Squid proxy policy generation including SSL bump mode, API proxy port routing, and DLP sections. The uncovered branches correspond to partial-configuration paths (e.g.,sslBump=truewithout CA files, or emptyapiProxyPortsarrays) that could silently misconfigure network isolation.domain-patterns.tshas 2 uncovered branches (89.47%) — thewildcardToRegexfunction leaves some metacharacter escape cases untested. Since incorrect regex generation could allow unintended domain access, these edge cases are security-relevant.config-writer.tsis the lowest-covered substantial file — at 82.79% statements and 78.94% branches (8 uncovered), error-handling paths during config file writes are not exercised. This matters because a failed write could leave the firewall starting with a stale or incomplete configuration.Recommendations
squid/config-sections.ts— add unit tests for: SSL bump enabled without CA files or DB path (partial SSL config),apiProxyPortsas an empty array vs undefined, and the regex-domain vs plain-domain ternary in port ACL generation. These paths control core proxy policy and a misconfiguration would silently weaken network isolation.config-writer.tsbranch coverage from 78.94% — add tests for file write failures, directory creation errors, and cleanup on partial writes. If AWF can't write its config, it should fail loudly rather than proceed with stale settings; these error paths need to be verified.domain-patterns.ts(2 branches),host-iptables-chain.ts(1 branch), andcli.ts(1 branch) — test all metacharacter escape cases inwildcardToRegex(e.g.,^,[,\), the iptables chain error path, and the CLI entry-point error branch. These are low-effort additions that complete coverage of security-adjacent code paths.Beta Was this translation helpful? Give feedback.
All reactions