[Schema Consistency] Schema Consistency Check - 2026-03-10

[github-actions[bot]]

Overview

This analysis used Strategy 23: Tool Parameter Schema Completeness Audit — targeting the same class of bug as commit 68a7f67 (Fix: max-patch-size missing from tools.repo-memory JSON schema). The strategy systematically cross-references every parameter across: frontmatter JSON schema, LLM tool definition JSON files, Go compiler struct tags, and documentation.

• Strategy: New approach (day 69, 69 mod 10 = 9 → new strategy)
• New Inconsistencies Found: 2
• Persistent Unresolved Issues: 10
• Workflow Run: §22896897915

---

Critical Issues (New This Run)

1. state-reason Missing from Frontmatter JSON Schema

The state-reason field is fully implemented in Go code and documented, but absent from the JSON schema for safe-outputs.close-issue.

Layer	Status
Go struct (close_entity_helpers.go:72)	✅ StateReason string \yaml:"state-reason,omitempty"``
Compiler (compiler_safe_outputs_config.go:204)	✅ AddIfNotEmpty("state_reason", c.StateReason)
Documentation (safe-outputs.md:218, 223)	✅ Documented with all 3 values
main_workflow_schema.json (safe-outputs.close-issue)	❌ MISSING
frontmatter-full.md (auto-generated from schema)	❌ MISSING (derives from schema)

The schema's close-issue object only has: required-labels, required-title-prefix, target, max, target-repo, allowed-repos — state-reason is not present.

Impact: Schema validation will reject state-reason with additionalProperties: false enforced. Users who follow the schema for editor validation or tooling will be told the field is invalid — even though the compiler happily accepts it. The frontmatter-full.md reference doc will not show this option.

Fix: Add state-reason to safe-outputs.close-issue schema object with enum ["completed", "not_planned", "duplicate"].

---

2. state_reason Parameter Missing from pkg/workflow/js/safe_outputs_tools.json

The close_issue LLM tool definition is inconsistent between the two runtime JSON files:

File	Has state_reason parameter?
actions/setup/js/safe_outputs_tools.json (line 176)	✅ Present (enum: COMPLETED, NOT_PLANNED, DUPLICATE)
pkg/workflow/js/safe_outputs_tools.json	❌ MISSING

The actions/setup version also has a different (shorter) description for close_issue compared to the pkg/workflow version.

Impact: Workflows running via the pkg/workflow code path will not expose state_reason to the LLM agent, so the agent cannot set the close reason. The agent must use an unstructured approach or the default (COMPLETED) is always used.

Fix: Add state_reason parameter to close_issue in pkg/workflow/js/safe_outputs_tools.json to match actions/setup version.

---

Persistent Unresolved Issues (from previous runs)

These issues have been reported in prior runs and remain unresolved:

#	Severity	Description	First Reported
1	CRITICAL	set_issue_type tool absent from actions/setup/js/safe_outputs_tools.json but present in pkg/workflow/js/	strategy-22
2	HIGH	temporary_id regex mismatch: safe-outputs-specification.md:1813 uses ^aw_[A-Za-z0-9]{3,8}$ (max 8) but safe_outputs_tools.json:36,271 uses ^aw_[A-Za-z0-9]{3,12}$ (max 12)	strategy-20
3	HIGH	mark-pull-request-as-ready-for-review tool not documented in safe-outputs.md (only in frontmatter-full.md)	strategy-22
4	HIGH	push_repo_memory agent tool undocumented — not in repo-memory.md, safe-outputs.md, or safe-outputs-specification.md	strategy-22
5	HIGH	set-issue-type safe-output not documented in safe-outputs.md (only in frontmatter-full.md)	strategy-20
6	MEDIUM	Nested deprecated: true fields in schema never trigger deprecation warnings (schema_deprecation.go only checks top-level)	strategy-22
7	MEDIUM	assign-to-user and unassign-from-user examples in safe-outputs.md don't show the blocked field	strategy-20
8	MEDIUM	max-continuations missing from frontmatter.md and engines.md	strategy-20
9	MEDIUM	status-comment missing from frontmatter.md	strategy-20
10	MEDIUM	reaction field: schema declares default: eyes but compiler only applies it for command/slash_command triggers, not for regular triggers	strategy-21

---

Recommendations

1. Add state-reason to main_workflow_schema.json under safe-outputs.close-issue.properties with enum values completed, not_planned, duplicate. This is the same class of fix as max-patch-size (commit 68a7f67).

2. Sync pkg/workflow/js/safe_outputs_tools.json close_issue tool to include the state_reason parameter matching the actions/setup version (enum: COMPLETED, NOT_PLANNED, DUPLICATE).

3. Consider a sync check test that compares pkg/workflow/js/safe_outputs_tools.json with actions/setup/js/safe_outputs_tools.json to prevent drift. The two files have diverged on 2 tools already.

4. Resolve set_issue_type sync — add the missing tool to actions/setup/js/safe_outputs_tools.json.

---

Strategy Performance

• Strategy Used: Strategy-23 — Tool Parameter Schema Completeness Audit
• Approach: Python script cross-referencing tool parameters across both JSON files; grep of Go struct yaml tags; schema JSON traversal
• Findings: 2 new issues
• Effectiveness: HIGH — directly replicates the detection method that found max-patch-size
• Should Reuse: YES — good systematic coverage of this specific bug class

References:

• §22896897915

AI generated by Schema Consistency Checker · history

• expires on Mar 11, 2026, 10:05 AM UTC

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-03-11T10:05:36.131Z.

Closed by Workflow