Terminal Stylist Audit: Console Output Patterns Analysis

[github-actions[bot]]

This report presents findings from a full scan of Go source files in pkg/ and cmd/ for console output patterns, Lipgloss styling usage, and Huh interactive form implementations.

Totals scanned: ~250 non-test .go files | 3,421 fmt.Print* usages | 1,556 console.* usages

---

Summary

Category	Status	Notes
Adaptive colors (Lipgloss)	✅ Excellent	Centralized in pkg/styles with AdaptiveColor
TTY detection	✅ Excellent	applyStyle() gates all styling; pkg/tty used consistently
Accessibility mode (Huh)	✅ Excellent	All forms use .WithAccessible(console.IsAccessibleMode())
Structured data output routing	✅ Correct	JSON/hashes/graphs go to stdout; diagnostics to stderr
Double emoji anti-pattern	⚠️ Found	FormatSuccessMessage("✓ ...") duplicates the built-in icon
Mixed formatting consistency	⚠️ Found	audit_report_render.go, deps_report.go mix styles
Raw diagnostic messages	⚠️ Found	Several files bypass console formatters for info messages
Huh form theming	ℹ️ Opportunity	No forms use .WithTheme() to match the palette in pkg/styles

---

Strengths

✅ Lipgloss: Adaptive Color System (pkg/styles)

pkg/styles/theme.go defines a thorough adaptive palette with documented light/dark hex values:

ColorError = lipgloss.AdaptiveColor{
    Light: "#D73737", // Darker red for light backgrounds
    Dark:  "#FF5555", // Bright red (Dracula theme)
}

All format functions in pkg/console/console.go apply styles conditionally via applyStyle():

func applyStyle(style lipgloss.Style, text string) string {
    if isTTY() { // checks tty.IsStdoutTerminal()
        return style.Render(text)
    }
    return text // plain text for pipes/redirects
}

This cleanly prevents ANSI codes from polluting piped output.

✅ Huh Forms: Consistent Accessibility Support

Every interactive form across 13+ files correctly uses:

huh.NewForm(...).WithAccessible(console.IsAccessibleMode())

IsAccessibleMode() checks ACCESSIBLE, TERM=dumb, and NO_COLOR environment variables — a solid multi-signal approach.

Files with correct accessibility usage: run_interactive.go, add_interactive_engine.go, add_interactive_workflow.go, add_interactive_auth.go, add_interactive_schedule.go, add_interactive_orchestrator.go, add_interactive_git.go, engine_secrets.go, interactive.go, console/input.go, console/confirm.go.

✅ Output Routing: stdout vs stderr

Structured data correctly routes to stdout for piping:

• fmt.Println(string(jsonBytes)) — JSON output (health, status, run)
• fmt.Println(hash) — Hash output
• fmt.Println(mermaidGraph) — Graph output
• fmt.Println(string(result.State)) — Checks state

Diagnostic output correctly routes to stderr with fmt.Fprintln(os.Stderr, console.Format*(...)).

---

Issues Found

⚠️ Double Emoji Anti-Pattern

FormatSuccessMessage, FormatWarningMessage, and FormatInfoMessage already prepend icons (✓ , ⚠ , ℹ ). Passing emoji-prefixed strings to these functions results in duplicated icons in TTY mode.

Affected files and lines:

File	Pattern	Result
pkg/cli/fix_command.go:233,251	FormatInfoMessage("✓ No fixes needed")	ℹ ✓ No fixes needed
pkg/cli/fix_command.go:322	FormatSuccessMessage("✓ "+fileName)	✓ ✓ filename
pkg/cli/fix_command.go:327	FormatWarningMessage("⚠ "+fileName)	⚠ ⚠ filename
pkg/cli/run_interactive.go:100	FormatSuccessMessage("✓ Workflow dispatched successfully!")	✓ ✓ Workflow...
pkg/cli/update_extension_check.go:65,87	FormatSuccessMessage("✓ gh-aw extension...")	✓ ✓ gh-aw...
pkg/cli/project_command.go:158,179,186,195	FormatSuccessMessage("✓ ...")	✓ ✓ ...
pkg/cli/upgrade_command.go:187,224,288	FormatSuccessMessage("✓ ...")	✓ ✓ ...

Fix: Remove emoji prefix from the string passed to the formatter:

// ❌ Before
fmt.Fprintln(os.Stderr, console.FormatSuccessMessage("✓ Upgrade complete"))

// ✅ After
fmt.Fprintln(os.Stderr, console.FormatSuccessMessage("Upgrade complete"))

---

⚠️ Mixed Formatting in audit_report_render.go

pkg/cli/audit_report_render.go (581 lines) uses console.FormatSectionHeader() and console.RenderTable() for structure but falls back to raw fmt.Fprintf(os.Stderr, ...) with hardcoded emoji for list items and findings — bypassing the consistent styling system.

View specific examples

// List items — bypasses console.FormatListItem
fmt.Fprintf(os.Stderr, "  • %s (%s)", file.Path, formattedSize)   // line 75
fmt.Fprintf(os.Stderr, "  • %s\n", tool.Tool)                     // line 89
fmt.Fprintf(os.Stderr, "  • %s: %s\n", failure.ServerName, ...)   // line 110

// Severity indicators — hardcoded emoji, inconsistent with console package icons
fmt.Fprintf(os.Stderr, "  🔴 %s [%s]\n", console.FormatErrorMessage(finding.Title), ...) // line 449
fmt.Fprintf(os.Stderr, "  🟡 %s [%s]\n", finding.Title, ...)      // line 469
fmt.Fprintf(os.Stderr, "  ℹ️  %s [%s]\n", finding.Title, ...)     // line 479

// Network stats — raw emoji instead of console formatters
fmt.Fprintf(os.Stderr, "    ✓ %s (%d requests)\n", domain, ...)   // line 360
fmt.Fprintf(os.Stderr, "    ✗ %s (%d requests)\n", domain, ...)   // line 371

Recommendations:

• Use console.FormatListItem(item) for bullet list entries
• Replace console.FormatErrorMessage(finding.Title) embedded in a raw printf with a structured helper
• Consider adding console.FormatFindingMessage(severity, title, category string) to standardize severity rendering

---

⚠️ Raw Diagnostic Messages in compile_helpers.go

pkg/cli/compile_helpers.go bypasses console formatters for error list rendering:

// Lines 300, 315 — should use console.FormatErrorMessage
fmt.Fprintf(os.Stderr, "  ✗ %s\n", filepath.Base(failure.Path))
fmt.Fprintf(os.Stderr, "  ✗ %s\n", workflow)

// Line 200 — should use console.FormatInfoMessage
fmt.Fprintln(os.Stderr, "Watching for file changes")

---

⚠️ Raw Diagnostic Messages in deps_report.go and mcp_inspect_mcp.go

View details

pkg/cli/deps_report.go:

// Lines 176, 184 — hardcoded emoji with raw message
fmt.Fprintf(os.Stderr, "🔴 CRITICAL: Address %d security %s immediately\n", ...)
fmt.Fprintf(os.Stderr, "⚠️  Reduce v0.x exposure from %.0f%% to <30%%\n", ...)

// Should be:
fmt.Fprintln(os.Stderr, console.FormatErrorMessage(fmt.Sprintf("CRITICAL: Address %d security %s immediately", ...)))
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Reduce v0.x exposure from %.0f%% to <30%%", ...)))

pkg/cli/mcp_inspect_mcp.go:494:

// Raw markdown-style bold in terminal output
fmt.Fprintf(os.Stderr, "⚠️  **Destructive:** May perform destructive updates\n")
// Should be:
fmt.Fprintln(os.Stderr, console.FormatWarningMessage("Destructive: May perform destructive updates"))

---

Opportunities

ℹ️ Huh Form Theming

No form in the codebase uses .WithTheme() to align interactive field colors with pkg/styles. The Charmbracelet Huh library supports custom themes via huh.NewTheme(). Applying a theme derived from pkg/styles colors would create visual consistency between form prompts and the rest of the CLI output.

// Opportunity: Create a shared theme derived from pkg/styles
// pkg/console/theme.go
var AWTheme = huh.NewTheme(...)

// Usage
huh.NewForm(...).
    WithAccessible(console.IsAccessibleMode()).
    WithTheme(console.AWTheme)

ℹ️ Inline lipgloss.NewStyle() in console.go RenderTable

pkg/console/console.go:168 uses lipgloss.NewStyle() directly in the styleFunc within RenderTable. These could reference pkg/styles constants for better centralization.

---

Recommendations by Priority

Priority	Action	Files
High	Remove duplicate emoji from Format* call arguments	fix_command.go, run_interactive.go, update_extension_check.go, project_command.go, upgrade_command.go
Medium	Replace raw emoji+printf with console formatters for findings	audit_report_render.go
Medium	Use console.FormatErrorMessage/InfoMessage for compile error lists	compile_helpers.go
Low	Use console formatters for MCP diagnostic messages	mcp_list_tools.go, mcp_inspect_mcp.go
Low	Use console formatters for security advisories	deps_report.go
Opportunity	Investigate Huh .WithTheme() for palette consistency	All interactive files

---

References: §23026731124

AI generated by Terminal Stylist · history

• expires on Mar 13, 2026, 10:29 PM UTC