[Schema Consistency] Schema Consistency Check – 2026-03-27

[github-actions[bot]]

Summary

• Inconsistencies Found: 4 (2 new + 2 confirmed persisting)
• Categories Analyzed: Schema ↔ Parser/Compiler, Schema ↔ Documentation, Compiler internals
• Strategy Used: Strategy-38 — FrontmatterConfig.ToMap() Serialization Completeness Audit
• Approach: Systematically diffed RuntimesConfig struct fields against runtimesConfigToMap() output, then compared all schema top-level property names against FrontmatterConfig JSON struct tags using shell diff

---

Critical Issues

HIGH: runtimesConfigToMap() Silently Drops 5 of 11 Runtimes

pkg/workflow/frontmatter_types.go:677–763 — runtimesConfigToMap() only serializes 6 runtimes but RuntimesConfig defines 11.

Runtimes in struct but NOT emitted:

• dotnet (line 31), elixir (line 32), haskell (line 33), java (line 34), ruby (line 35)

All five are valid runtimes confirmed in:

• main_workflow_schema.json (patternProperties, examples at lines 3834–3845 and 3956+)
• runtime_definitions.go (lines 55, 65, 91, 101, 137)
• RuntimesConfig struct (frontmatter_types.go:31–35)

The bug manifests when RuntimesTyped is populated (i.e. ParseFrontmatterConfig() succeeds): ToMap() at line 561 calls runtimesConfigToMap(fc.RuntimesTyped) which discards those 5 runtimes. If RuntimesTyped is nil the raw Runtimes map is used instead, which preserves all keys correctly.

countRuntimes() (lines 467–491) has the same gap — it counts only node, python, go, uv, bun, deno (6 of 11).

Impact: Any code that calls FrontmatterConfig.ToMap() on a workflow with dotnet/elixir/haskell/java/ruby runtime overrides will silently lose those overrides. The main compiler path (runtime_detection.go:29) uses workflowData.Runtimes (raw map[string]any) directly, so compiled workflows are unaffected today — but this is a silent correctness trap for any new code that depends on ToMap().

---

MEDIUM: runtimesConfigToMap() Also Drops action-repo and action-version for All Runtimes

RuntimeConfig struct defines ActionRepo and ActionVersion (frontmatter_types.go:17–18) and parseRuntimesConfig() correctly extracts them (lines 305–306). But runtimesConfigToMap() only emits version and if — action-repo and action-version are never written back.

These fields are schema-documented and fully functional at compile time (runtime_overrides.go:40–42 reads them from the raw map). The frontmatter.md docs show an example (lines 152–221) with action-repo and action-version. So the only gap is the round-trip through runtimesConfigToMap().

No test in frontmatter_types_test.go covers action-repo/action-version round-trip — the existing TestRuntimesConfigToMapWithIfCondition only checks version and if.

---

Confirmed Persisting Issues

CONFIRMED: status-comment Schema Description Still Stale (Strategy-30, -35)

main_workflow_schema.json still says:

"Must be explicitly set to true to enable status comments - there is no automatic bundling with ai-reaction."

But compiler_safe_outputs.go:192–195 still auto-enables StatusComment = true for slash_command / label_command triggers when not explicitly set.

Two pending changesets will change this behavior:

• minor-decouple-status-comment.md (major breaking change): removes auto-enable entirely
• minor-enable-reaction-status-comment-by-default.md (minor): re-enables auto-default for both triggers

Until those are released the schema description is wrong. After release the schema description will need to be updated again to reflect the new default-on behavior. The description should be updated alongside whichever changeset ships last.

---

MEDIUM: FrontmatterConfig.ToMap() Omits Five Schema Fields

The following fields are defined in the FrontmatterConfig struct and in the schema but are never emitted by ToMap() (frontmatter_types.go:519–675):

Field	Struct line	Schema
Private (*bool)	149	✅ defined
RateLimit (*RateLimitConfig)	199	✅ defined
Observability (*ObservabilityConfig)	196	✅ defined
InlinedImports (bool)	190	✅ defined
Resources ([]string)	191	✅ defined

Current impact is low: FrontmatterConfig.ToMap() is not called in the main compiler path — WorkflowData uses raw map[string]any fields populated directly. However this is a correctness bug that would silently drop real user configuration for any code that depends on ToMap().

Additionally, include is a FrontmatterConfig field (line 189) and emitted by ToMap() (line 662) but is absent from the schema — either it is a legacy/internal field or it needs a schema entry. Similarly, version (line 146) is in the struct but not in the schema.

---

Recommendations

1. Fix runtimesConfigToMap() immediately — add serialization blocks for dotnet, elixir, haskell, java, ruby (mirroring the existing node/python/go/uv/bun/deno pattern), and add action-repo/action-version emission to all runtime blocks. Add a round-trip test.

2. Fix countRuntimes() in parallel — add the 5 missing runtime checks (impact: log messages undercount runtimes).

3. Update status-comment schema description when the minor-decouple-status-comment + minor-enable-reaction-status-comment-by-default changesets are released. Suggested description: "Whether to post status comments (started/completed) on the triggering item. Defaults to true for slash_command and label_command triggers. Set to false to disable."

4. Add ToMap() completeness test — a table-driven test that round-trips all FrontmatterConfig fields through ParseFrontmatterConfig → ToMap() and asserts no fields are silently dropped.

5. Clarify include and version in schema — add schema entries if they are valid frontmatter fields, or add additionalProperties: false enforcement with a comment explaining why they're struct-only.

---

Schema Analysis Method

# Extract schema top-level properties
jq -r '.properties | keys[]' pkg/parser/schemas/main_workflow_schema.json | sort

# Extract FrontmatterConfig struct JSON tags
awk '/^type FrontmatterConfig struct/,/^}/' pkg/workflow/frontmatter_types.go \
  | grep -oP 'json:"[^"]*"' | sed 's/json:"//;s/".*//' | sed 's/,omitempty//' | sort

# Diff shows: schema has bots, command, dependencies, disable-model-invocation, github-app, infer
# not in struct (handled via raw maps); struct has 'include' and 'version' not in schema

---

Strategy Performance

• Strategy Used: FrontmatterConfig.ToMap() Serialization Completeness Audit
• Findings: 4 (2 new code bugs, 1 confirmed schema stale, 1 confirmed ToMap gap)
• Effectiveness: HIGH — struct/schema diff is a fast, repeatable method
• Should Reuse: YES — can be applied to other sub-structs (RuntimeConfig, SafeOutputsConfig, etc.)

---

Next Steps

• Fix runtimesConfigToMap() — add dotnet/elixir/haskell/java/ruby + action-repo/action-version
• Fix countRuntimes() — add the 5 missing runtime counters
• Add round-trip test for runtimesConfigToMap covering all 11 runtimes and all RuntimeConfig fields
• Add ToMap() completeness regression test for FrontmatterConfig
• Update status-comment schema description when decouple changeset ships
• Audit schema for include and version top-level fields — add or intentionally exclude
• Continue backlog: proxy-args in MCP schema, update-discussion labels dead feature, codemod registry mismatch, close-older-key docs, set-issue-type/mark-PR-ready docs, copilot-requests feature flag docs, disable-xpia-prompt docs, observability.job-summary docs

References:

• §23631170891

AI generated by Schema Consistency Checker · history

• expires on Mar 28, 2026, 4:39 AM UTC

[github-actions[bot]]

This discussion has been marked as outdated by Schema Consistency Checker.

A newer discussion is available at Discussion #23314.