[lint-monster] Daily Lint Scan Report - 2026-06-07

[github-actions[bot]]

Daily Lint Scan Summary

Date: 2026-06-07
Total Findings: 835

Group Breakdown

Group 1: Function-Length Refactoring (638 findings)

Issue: Functions exceeding 60-line limit

• Affected Packages: pkg/workflow (~460), pkg/cli (~178)
• Severity: High impact on maintainability and testability
• Tracking Issue: #aw_func_length - Consolidated authoritative tracking issue
• Top Candidates:
  • copilot_engine_execution.go: GetExecutionSteps (633 lines)
  • compiler_pre_activation_job.go: buildPreActivationJob (489 lines)
  • claude_engine.go: GetExecutionSteps (382 lines)
  • compiler_main_job.go: buildMainJob (389 lines)

Group 2: Map Set Efficiency (185 findings)

Issue: map[string]bool used as sets instead of map[string]struct{}

• Affected Packages: pkg/workflow (~113), pkg/cli (~72)
• Memory Impact: Wastes 1 byte per entry (boolean allocation)
• Tracking Issue: #aw_map_set
• Remediation: Mechanical replacement with minimal risk
• High-Concentration Files:
  • pkg/cli/firewall_log.go (5 occurrences)
  • pkg/workflow/domains.go (5 occurrences)

Group 3: Error Handling + Parameters (12 findings)

Issues:

1. Unchecked json.Marshal error returns (11 findings)
2. Function parameter count exceeds limit (1 finding)

• Affected Files:
  • pkg/cli/staged_filtering_test.go (3 occurrences in tests)
  • pkg/workflow/add_comment_target_repo_test.go (2 occurrences in tests)
  • Production files with similar patterns (6+ occurrences)
• Tracking Issue: #aw_errors_params
• Risk: Low for test files, medium for production

Related Issues

Existing Issue: #37243 - "[lint-monster] [Lint] Miscellaneous Fixes: Error Handling + String Comparison - 29 findings"

• Status: Open from 2026-06-06
• Different findings (string comparison, additional error handling)
• Not duplicated with current Group 3 findings

Action Items

✅ Completed:

• Created 3 tracking issues for lint groups
• Consolidated function-length findings into single authoritative issue
• Documented remediation strategies for each group

Next Steps:

• Assign agents to function-length and map-set efficiency groups
• Monitor progress via issue updates
• Re-run lint scan after fixes to validate

Notes

• No duplicate lint-monster issues found from prior runs for the same finding types
• Function-length is the largest blocker and best starting point
• Map-set efficiency fixes are mechanical and lower-risk
• Error handling issues should be addressed cautiously due to test file side effects

Generated by 🧌 LintMonster · 95 AIC · ⌖ 7.17 AIC · ⊞ 19.9K · ◷

• expires on Jun 9, 2026, 3:51 AM UTC

[github-actions[bot]]

This discussion has been marked as outdated by LintMonster.

A newer discussion is available at Discussion #37728.