[repository-quality] Context Propagation & Process Cancellability — Reuse Run

[github-actions[bot]]

🎯 Repository Quality Improvement Report — Context Propagation & Process Cancellability (Reuse)

Analysis Date: 2026-06-09
Focus Area: Context Propagation & Process Cancellability
Strategy Type: Reuse (random=93, 10% tier — most impactful area from last 10 runs)
Custom Area: No

Executive Summary

Zero progress has been made since the June 3 analysis. The repository still has 109 bare exec.Command calls in non-test Go source across 32 files, versus only 24 exec.CommandContext calls — a context-adoption rate of 18%. This means 82% of subprocess spawns are completely un-cancellable regardless of timeouts or signals held by callers.

The most acute risk is in network-touching operations: pkg/parser/remote_fetch.go spawns 13 git processes (clone, ls-remote, archive, ls-tree) with no cancellation hooks, and pkg/cli/run_push.go executes git push/commit/stage without the ctx that its callers already hold. The existing ctxbackground linter covers context.Background() misuse but does not flag exec.Command called inside functions that already receive a context.Context.

Current State Assessment

Metrics Collected:

Metric	Value	Status
exec.Command (non-test)	109	❌
exec.CommandContext (non-test)	24	⚠️
Context adoption rate	18%	❌
Files with bare exec.Command	32	❌
pkg/cli/git.go bare calls	18	❌
pkg/parser/remote_fetch.go bare calls	13	❌
pkg/cli/run_push.go bare calls	4	❌
pkg/workflow/git_helpers.go bare calls	1	⚠️
Progress since 2026-06-03	0 changes	❌
ctxbackground linter scope	context.Background() only	⚠️

Key Findings:

• pushWorkflowFiles() in run_push.go (line 373) has 4 git subprocess calls; callers hold ctx but do not pass it
• pkg/cli/git.go: 18 bare calls, no function in file accepts ctx — push, commit, checkout all un-cancellable
• pkg/parser/remote_fetch.go: 13 network-touching git calls in functions with no ctx parameter
• pkg/workflow/github_cli.go has a working setupGHCommand(ctx, ...) pattern that serves as a template
• ctxbackground linter exists but does not catch exec.Command in context-receiving functions

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Improvement Tasks

Task 1: Thread Context into pushWorkflowFiles in run_push.go

Priority: High
Estimated Effort: Small
Focus Area: Context Propagation

Description: pushWorkflowFiles() (line 373) executes 4 git subprocesses (lines 387, 400, 543, 557) using bare exec.Command. Add ctx context.Context as the first parameter and replace all four calls with exec.CommandContext(ctx, ...). Update call sites.

Acceptance Criteria:

• pushWorkflowFiles(ctx context.Context, ...) signature updated
• All 4 exec.Command("git", ...) inside function converted to exec.CommandContext(ctx, "git", ...)
• All call sites pass ctx
• go build ./... passes

Code Region: pkg/cli/run_push.go

In `pkg/cli/run_push.go`, update `pushWorkflowFiles` to accept `ctx context.Context` as the first parameter. Replace the four bare `exec.Command` calls at lines ~387, ~400, ~543, and ~557 with `exec.CommandContext(ctx, ...)`. Update all call sites to pass the available context. Ensure `go build ./...` passes.

---

Task 2: Add Context-Aware Git Variants in pkg/cli/git.go

Priority: High
Estimated Effort: Medium
Focus Area: Context Propagation

Description: pkg/cli/git.go has 18 bare exec.Command calls; no function accepts a context. Network-touching functions — getCurrentBranch, createAndCheckoutBranch, checkoutBranch, commitAll, pushBranch, getGitStatus, stageWorkflowChanges — should accept ctx context.Context and use exec.CommandContext. Follow the pattern in pkg/workflow/github_cli.go::setupGHCommand.

Acceptance Criteria:

• Network-touching functions in pkg/cli/git.go accept ctx context.Context
• exec.Command replaced with exec.CommandContext(ctx, ...) in those functions
• Call sites in pkg/cli/ updated to pass ctx from cobra command context
• Non-network utility functions left unchanged
• go build ./... passes

Code Region: pkg/cli/git.go

In `pkg/cli/git.go`, add `ctx context.Context` to `getCurrentBranch`, `createAndCheckoutBranch`, `checkoutBranch`, `commitAll`, `pushBranch`, `getGitStatus`, and `stageWorkflowChanges`. Replace their `exec.Command` calls with `exec.CommandContext(ctx, ...)`. Update callers to thread context from cobra. Reference `pkg/workflow/github_cli.go::setupGHCommand` as pattern. Run `go build ./...`.

---

Task 3: Add execcommandnocontext Linter

Priority: Medium
Estimated Effort: Medium
Focus Area: Context Propagation

Description: Create an analyzer pkg/linters/execcommandnocontext/ that flags exec.Command(...) calls inside functions already receiving a context.Context parameter. Modeled after pkg/linters/ctxbackground/. Register in cmd/linters/main.go, add to spec_test.go and README.md.

Acceptance Criteria:

• New analyzer pkg/linters/execcommandnocontext/execcommandnocontext.go created
• Flags exec.Command(...) in functions with a context.Context parameter; suggests exec.CommandContext(<ctx_param>, ...)
• Skips test files via filecheck.IsTestFile
• Registered in cmd/linters/main.go
• Added to pkg/linters/spec_test.go and pkg/linters/README.md
• Test data in pkg/linters/execcommandnocontext/testdata/
• go test ./pkg/linters/... passes

Code Region: pkg/linters/execcommandnocontext/, cmd/linters/main.go, pkg/linters/spec_test.go

Create `pkg/linters/execcommandnocontext/execcommandnocontext.go`. It should flag any `exec.Command(...)` call inside a function that has a `context.Context` parameter, suggesting `exec.CommandContext(<ctx_param>, ...)`. Model after `pkg/linters/ctxbackground/ctxbackground.go`. Register in `cmd/linters/main.go`. Add to `pkg/linters/spec_test.go` and `pkg/linters/README.md`. Include `testdata/` with flagged and compliant cases. Run `go test ./pkg/linters/...`.

---

Task 4: Thread Context into git_helpers.go and Key remote_fetch.go Operations

Priority: Medium
Estimated Effort: Medium
Focus Area: Context Propagation

Description: runGitWithSpinner / RunGitCombined in git_helpers.go use bare exec.Command. Also update resolveRefToSHAViaGit, downloadFileViaGit, downloadFileViaGitClone in remote_fetch.go to accept ctx and use exec.CommandContext.

Acceptance Criteria:

• runGitWithSpinner(ctx context.Context, ...) and RunGitCombined(ctx, ...) updated
• All callers of RunGitCombined pass ctx
• resolveRefToSHAViaGit, downloadFileViaGit, downloadFileViaGitClone accept ctx and use exec.CommandContext
• go build ./... passes

Code Region: pkg/workflow/git_helpers.go, pkg/parser/remote_fetch.go

In `pkg/workflow/git_helpers.go`, update `runGitWithSpinner` and `RunGitCombined` to accept `ctx context.Context` and use `exec.CommandContext(ctx, ...)`. Update callers. In `pkg/parser/remote_fetch.go`, add ctx to `resolveRefToSHAViaGit` (~line 447), `downloadFileViaGit` (~line 557), and `downloadFileViaGitClone` (~line 634), replacing `exec.Command` with `exec.CommandContext(ctx, ...)`. Thread context from public callers. Run `go build ./...`.

---

📊 Historical Context

Previous Focus Areas (last 5)

Date	Focus Area	Type	Custom	Key Outcomes
2026-06-03	Context Propagation & Cancellability	Custom	Y	5 tasks, 3 high — 109 bare exec.Command, 18% adoption
2026-06-04	Linter Registry Completeness	Standard	N	4 tasks — 6 analyzers missing spec_test/docs
2026-06-05	Large File Refactoring (reuse)	Reuse	N	5 tasks — zero progress confirmed
2026-06-08	Compiler Error Hint Rendering Gap	Custom	Y	4 tasks — CompilerError.Hint never set in production
2026-06-09	Context Propagation (reuse)	Reuse	N	Zero progress confirmed; 4 focused tasks

---

🎯 Recommendations

Immediate Actions (This Week)

1. Thread ctx into pushWorkflowFiles() — 4 call sites, quick win — Priority: High
2. Add ctx to network functions in pkg/cli/git.go — Priority: High

Short-term Actions (This Month)

1. Create execcommandnocontext linter to prevent regression — Priority: Medium
2. Thread ctx into git_helpers.go + top-risk remote_fetch.go functions — Priority: Medium

Long-term Actions (This Quarter)

1. Systematic audit using new linter across all 109 remaining sites — Priority: Low

---

📈 Success Metrics

• Context adoption rate: 18% → ≥50% (after Tasks 1–2)
• Bare exec.Command in context-receiving functions: ~25 sites → 0 (after linter enforcement)
• Network-touching uncancellable calls: 26 → 0 (after Tasks 2 & 4)

---

Next Steps

1. Review and prioritise the tasks above
2. Assign tasks to Copilot coding agent via planner agent
3. Track progress via linter enforcement
4. Re-evaluate in 1 week

References: §27210400253

Generated by ⚡ Repository Quality Improvement Agent · 242.6 AIC · ⌖ 27.7 AIC · ⊞ 22.2K · ◷

• expires on Jun 10, 2026, 5:54 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-06-10T13:54:32.783Z.

Closed by Workflow