[terminal-stylist] Terminal Stylist: Console Output Analysis Report

[github-actions[bot]]

Overview

Terminal Stylist analysis of pkg/ console output patterns across 917 Go source files (excl. _test.go). The codebase uses a well-structured, layered approach: pkg/styles/ → pkg/console/ → pkg/cli/. Library stack: Lipgloss v2.0.3 and Huh v2.0.3 (charm.land custom forks).

Key Metrics

Metric	Value
Go source files scanned	917
Files with any fmt.Print* usage	444
console.Format* calls in pkg/cli/	~1,497
huh.NewForm() instances in pkg/cli/	17
Forms missing WithTheme / WithAccessible	0
Hardcoded lipgloss.Color() outside pkg/styles/	0
Manual ANSI escape sequences outside pkg/console/terminal.go	0

---

✅ Strengths

Adaptive Color System
pkg/styles/theme.go uses compat.AdaptiveColor for every color constant, with explicit Light/Dark hex variants. Color profile detection via colorprofile.Detect is wired at init, respecting NO_COLOR, TERM, and terminal capability bits.

TTY-Aware Rendering
pkg/console/console.go centralises TTY detection in applyStyle() — styles are only rendered when tty.IsStdoutTerminal() / tty.IsStderrTerminal() returns true, preventing ANSI codes in pipes or redirects.

Consistent Huh Theming
All 17 huh.NewForm() calls in pkg/cli/ append .WithTheme(styles.HuhTheme).WithAccessible(console.IsAccessibleMode()). The pkg/console/ wrappers (confirm.go, input.go, list.go) do the same. Zero exceptions found.

Rich Console API
pkg/console/ exposes 20+ typed format functions (FormatSuccessMessage, FormatWarningMessage, FormatInfoMessage, FormatErrorMessage, FormatCommandMessage, FormatProgressMessage, FormatListItem, FormatSectionHeader, etc.) plus structured rendering (RenderStruct, RenderTable, RenderTitleBox, RenderInfoSection).

Accessibility Mode
IsAccessibleMode() checks ACCESSIBLE, TERM=dumb, and NO_COLOR, and is propagated to every interactive Huh form to disable animations and simplify output.

No Colour Leakage
Zero lipgloss.Color() literals found outside pkg/styles/ and pkg/console/. All colour constants are defined once in pkg/styles/theme.go and consumed via named style objects.

---

⚠️ Areas for Improvement

1. Raw fmt.Fprintf(os.Stderr, ...) in pkg/cli/compile_stats.go (14 occurrences)

compile_stats.go uses console.FormatErrorMessage / FormatSuccessMessage for summary lines but falls back to raw fmt.Fprintf for the detailed error-report body and summary statistics. This breaks visual consistency — unstyled lines appear alongside styled ones in the same output block.

Affected lines (representative):

// Line 165 — unstyled failure marker
fmt.Fprintf(os.Stderr, "  ✗ %s\n", filepath.Base(failure.Path))

// Lines 186–191 — unstyled error detail
fmt.Fprintf(os.Stderr, "  %s %s:\n", prioritized.Severity.Icon(), heading)
fmt.Fprintf(os.Stderr, "    %d. %s\n", i+1, prioritized.Message)
fmt.Fprintf(os.Stderr, "       → %s\n", prioritized.Suggestion)

// Lines 333–336 — unstyled stats summary
fmt.Fprintf(os.Stderr, "  Total workflows: %d\n", len(statsList))
fmt.Fprintf(os.Stderr, "  Total jobs:      %d\n", totalJobs)

Recommendation: Wrap list items with console.FormatListItem(), apply styles.Error.Render() consistently to failure markers, and use console.FormatInfoMessage() for stats lines — matching the pattern already used in compile_stats.go lines 158 and 220.

Additionally, lines 301–302 use styles.Error.Render() directly (bypassing console.*) while line 158 uses console.FormatErrorMessage(). Normalise to console.FormatErrorMessage() or a dedicated compile-error format function.

2. Unstyled sub-bullets in pkg/cli/trial_confirmation.go

Lines 182–183 and 199–200 emit plain execution-step sub-items directly, while the surrounding step numbers use console.FormatInfoMessage():

// Lines 182–183 — no styling
fmt.Fprintf(os.Stderr, "     a. Execute %s\n", workflowName)
fmt.Fprintf(os.Stderr, "     b. Auto-merge any pull requests created during execution\n")

Lines 220 and 222 emit blank separator lines as fmt.Fprintln(os.Stderr, ""), and there are no visual separators between execution phase sections.

Recommendation: Style sub-items with console.FormatListItem() or an indented variant. Extract the blank-line separator into a small local helper (e.g., printBlank()) to reduce repetition.

3. Unformatted messages in vscode_config.go and mcp_config_file.go

vscode_config.go line 82:

fmt.Fprintf(os.Stderr, "Settings file already exists at %s\n", settingsPath)

This is a warning-level condition; console.FormatWarningMessage() should be used.

mcp_config_file.go lines 64, 108–109:

fmt.Fprintf(os.Stderr, "MCP server '%s' already configured in %s\n", ghAwServerName, mcpConfigPath)
fmt.Fprintln(os.Stderr, "To enable GitHub Copilot Agent MCP server integration, please add the following")
fmt.Fprintf(os.Stderr, "to the \"mcpServers\" section of your %s file:\n", filePath)

These are informational user instructions that would benefit from console.FormatInfoMessage() and console.FormatCommandMessage() styling to visually separate them from the JSON snippet that follows.

4. Inline Lipgloss style creation in pkg/cli/compile_schedule_calendar.go

intensityStyle() at line 200 creates lipgloss.Style{} and lipgloss.NewStyle() variants inline, bypassing the centralised pkg/styles/ palette:

func intensityStyle(count int, isTerminal bool) lipgloss.Style {
    if !isTerminal {
        return lipgloss.Style{}
    }
    // ... returns lipgloss.NewStyle().Foreground(...)

While the TTY check is correct, the colours used here should be defined as named constants in pkg/styles/ (e.g., ColorCalendarLow, ColorCalendarMedium) so they participate in the light/dark adaptive system.

5. Blank-line separator repetition

fmt.Fprintln(os.Stderr) is used as a blank-line visual separator in 20+ locations across compile_stats.go, mcp_config_file.go, mcp_inspect.go, compile_schedule_calendar.go, and others. While functional, this pattern is verbose and easy to forget.

pkg/console/ could expose a PrintBlankLine() helper (analogous to PrintBanner()) to make intent explicit and allow future behaviour changes (e.g., suppressing blanks in non-TTY mode) without touching every call site.

---

Lipgloss-Specific Recommendations

Pattern	Status	Recommendation
Adaptive colors (compat.AdaptiveColor)	✅ Used throughout pkg/styles/	—
TTY detection before styling	✅ Centralised in applyStyle()	—
Color profile detection	✅ colorprofile.Detect at init	—
Inline lipgloss.Color() outside styles	✅ None found	—
Table rendering	✅ RenderTable uses lipgloss/table with style func	—
Calendar intensity styles	⚠️ Inline in compile_schedule_calendar.go	Move to pkg/styles/ with named constants
Border/layout consistency	✅ DoubleBorder, NormalBorder used in console.go	—

Huh-Specific Recommendations

Pattern	Status	Recommendation
WithTheme(styles.HuhTheme) on all forms	✅ 17/17 in pkg/cli/, 3/3 in pkg/console/	—
WithAccessible(console.IsAccessibleMode())	✅ 17/17 forms	—
Field validation	✅ Present on Input fields	—
Suggestions() on text inputs	✅ Used in interactive.go	Consider adding to other open-ended inputs
Multi-group form organisation	✅ Logical grouping in interactive.go	—
huh.Note for long instructions	i️ Not observed	Consider for the MCP config instructional block currently using raw fmt.Fprintf

Next Actions

1. compile_stats.go — Replace 14 raw fmt.Fprintf(os.Stderr, ...) with console.FormatListItem(), console.FormatInfoMessage(), and consistent styles.Error.Render() usage.
2. vscode_config.go / mcp_config_file.go — Replace 3 unformatted info/warning messages with console.FormatWarningMessage() / console.FormatInfoMessage().
3. compile_schedule_calendar.go — Move calendar intensity colours into pkg/styles/ as adaptive colour constants.
4. pkg/console/ — Consider adding a PrintBlankLine() helper to reduce fmt.Fprintln(os.Stderr) boilerplate.

References:

• §27610710789

Generated by 💄 Terminal Stylist · 483.5 AIC · ⌖ 42.5 AIC · ⊞ 21K · ◷

• expires on Jun 17, 2026, 2:28 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-06-17T10:28:51.686Z.

Closed by Workflow