[repository-quality] 🎯 Repository Quality Improvement Report - Benchmark Infrastructure Completeness & Regression Prevention [Reuse Run]

[github-actions[bot]]

🎯 Repository Quality Improvement Report - Benchmark Infrastructure Completeness & Regression Prevention

Analysis Date: 2026-06-16
Focus Area: Benchmark Infrastructure Completeness & Regression Prevention
Strategy Type: Reuse (random=97, 10% tier) — first reuse of 2026-06-11 report

Executive Summary

Zero progress on all five tasks from the June 11 report. The repo has 93 benchmark functions across 21 files; only 15 (16%) call b.ReportAllocs(). benchstat remains uninstalled. Three table-driven benchmark subtests still use for range b.N instead of b.Loop() (Go 1.24+); the codebase targets Go 1.26.3 and 97% of loops already use b.Loop().

Full Analysis

Metrics:

Metric	Value	Status
Total benchmark functions	93	✅
Files with b.ReportAllocs()	3 / 21	❌
Benchmarks with alloc tracking	15 / 93 (16%)	❌
benchstat in CI	No	❌
Loops using b.Loop()	90 / 93	⚠️
for range b.N loops	3 / 93	⚠️
Regression threshold configured	No	❌
Progress since 2026-06-11	Zero	❌

Files missing b.ReportAllocs() (18 files, 78 benchmarks):
expressions_benchmark_test.go (11), logs_benchmark_test.go (10), processing_benchmark_test.go (7), compiler_benchmark_test.go (7), sanitize_test.go (7), stringutil_test.go (6), regex_benchmark_test.go (6), frontmatter_benchmark_test.go (4), envutil_test.go (4), concurrency_validation_test.go (3), expression_parser_comprehensive_test.go (2), js_test.go (2), commands_utils_test.go (2), repoutil_test.go (2), identifiers_test.go (2), js_comments_test.go (1), mcp_benchmark_test.go (1), urls_test.go (1)

for range b.N sites: pkg/stringutil/urls_test.go:130, pkg/workflow/js_comments_test.go:713, pkg/workflow/concurrency_validation_test.go:644

Reference implementation: pkg/cli/compile_security_benchmark_test.go — all 7 benchmarks use b.ResetTimer() + b.ReportAllocs() + b.Loop().

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

---

Task 1: Add b.ReportAllocs() to All 78 Missing Benchmarks

Priority: High | Effort: Small

Description: 78 benchmarks lack b.ReportAllocs(), hiding allocation regressions. Add it before the loop in all 18 affected files, after b.ResetTimer() when present.

Acceptance Criteria:

• Every func BenchmarkXxx calls b.ReportAllocs() before its loop
• go test -run=^$ -bench=. -benchmem ./pkg/... passes

Code Region: pkg/workflow/*_benchmark_test.go, pkg/cli/*_benchmark_test.go, pkg/stringutil/*_test.go, pkg/parser/frontmatter_benchmark_test.go, pkg/envutil/envutil_test.go, pkg/repoutil/repoutil_test.go

Add b.ReportAllocs() to every benchmark missing it in github/gh-aw. Affected files (18 in pkg/): workflow/expressions_benchmark_test.go, processing_benchmark_test.go, compiler_benchmark_test.go, regex_benchmark_test.go, concurrency_validation_test.go, expression_parser_comprehensive_test.go, js_test.go, js_comments_test.go, mcp_benchmark_test.go; cli/logs_benchmark_test.go, commands_utils_test.go; stringutil/sanitize_test.go, stringutil_test.go, identifiers_test.go, urls_test.go; parser/frontmatter_benchmark_test.go; envutil/envutil_test.go; repoutil/repoutil_test.go. Place after b.ResetTimer() if present, else before the loop. Reference: pkg/cli/compile_security_benchmark_test.go. Run make fmt and go test -run=^$ -bench=. -benchmem ./pkg/...

---

Task 2: Install benchstat and Wire Regression Detection into CI

Priority: High | Effort: Medium

Description: benchstat referenced in 4 Makefile comments but never installed. daily-cli-performance stores bench_results.txt but never compares to baseline. Add install target, comparison target, and wire ≥10% regression detection into the CI workflow.

Acceptance Criteria:

• make bench-install-tools installs benchstat via go install golang.org/x/perf/cmd/benchstat@latest
• make bench-compare runs benchstat <baseline> <new> producing bench_diff.txt
• daily-cli-performance.md fires create-issue on ≥10% wall-time or ≥20% alloc regression

Code Region: Makefile, .github/workflows/daily-cli-performance.md

Integrate benchstat for regression detection in github/gh-aw. 1) Makefile: add bench-install-tools (go install golang.org/x/perf/cmd/benchstat@latest); update bench-compare to download previous bench_results.txt from branch memory/cli-performance and run benchstat <old> <new> > bench_diff.txt. 2) .github/workflows/daily-cli-performance.md: after running benchmarks, compare via benchstat; if regression >10% wall-time or >20% allocs detected, use create-issue safe-output to file an issue. Run make bench-install-tools && make fmt.

---

Task 3: Migrate for range b.N to b.Loop() in 3 Files

Priority: Medium | Effort: Small

Description: Three subtest loops use for range b.N instead of b.Loop(). The repo targets Go 1.26.3; 97% of loops already use b.Loop().

Acceptance Criteria:

• pkg/stringutil/urls_test.go:130, pkg/workflow/js_comments_test.go:713, pkg/workflow/concurrency_validation_test.go:644 updated
• grep -rn "for range b\.N" --include="*_test.go" returns no results

Code Region: pkg/stringutil/urls_test.go, pkg/workflow/js_comments_test.go, pkg/workflow/concurrency_validation_test.go

In github/gh-aw (Go 1.26.3), change `for range b.N {` to `for b.Loop() {` at: pkg/stringutil/urls_test.go:130, pkg/workflow/js_comments_test.go:713, pkg/workflow/concurrency_validation_test.go:644. Verify grep finds no remaining `for range b.N` in test files. Run make fmt and go test -run=^$ -bench=. -benchmem ./pkg/stringutil/... ./pkg/workflow/...

---

Task 4: Add benchreportallocs Linter

Priority: Medium | Effort: Medium

Description: After Task 1, prevent future omissions with a custom Go analyzer flagging func BenchmarkXxx bodies missing b.ReportAllocs().

Acceptance Criteria:

• pkg/linters/benchreportallocs/analyzer.go implemented and tested
• Registered in cmd/linters/main.go; documented in pkg/linters/README.md
• make lint passes

Code Region: pkg/linters/, cmd/linters/main.go, pkg/linters/README.md

Add benchreportallocs linter in github/gh-aw. Create pkg/linters/benchreportallocs/ with analyzer.go (flags BenchmarkXxx functions missing b.ReportAllocs() call: "benchmark function %s is missing b.ReportAllocs() call"), analyzer_test.go with passing/failing cases, and testdata. Register in cmd/linters/main.go; add to pkg/linters/README.md table. Run make lint and go test ./pkg/linters/...

---

📊 Historical Context

Last 5 focus areas

Date	Focus Area	Type	Custom
2026-06-11	Benchmark Infrastructure	Custom	Y
2026-06-12	Cobra Example Field Migration	Custom	Y
2026-06-15	Documentation	Standard	N
2026-06-16	Benchmark Infrastructure (reuse)	Reuse	N

---

📈 Success Metrics

• b.ReportAllocs() coverage: 16% → 100%
• benchstat integration: None → Wired in CI with regression alerts
• for range b.N: 3 → 0
• Regression detection: Manual → Automated (≥10% triggers issue)

---

References: §27624899391

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by ⚡ Repository Quality Improvement Agent · 346.3 AIC · ⌖ 25.8 AIC · ⊞ 22K · ◷

• expires on Jun 17, 2026, 6:41 AM UTC-08:00