[lint-monster] [LintMonster] Daily Lint Scan Report – 2026-06-18

[github-actions[bot]]

Daily Lint Scan Report

Date: 2026-06-18
Total Findings: 968
Unique Files Affected: 550+

---

Lint Findings Summary

✅ Group 1: Performance Optimization – map[string]bool → map[string]struct{}

Findings: 187 instances across 108 files

Severity: Low (performance/memory efficiency)

Description: Maps using bool values as sets allocate memory per entry unnecessarily. Refactor to use map[string]struct{} for zero-size struct values.

Affected Subsystems:

• pkg/cli/ (31 files)
• pkg/workflow/
• pkg/parser/
• pkg/github/
• pkg/linters/
• pkg/schema/
• pkg/agentdrain/

Action: Created issue #aw_map_set_opt

---

✅ Group 2: Code Maintainability – Extract Hardcoded Paths

Findings: 120 instances across 55 files

Severity: Medium (maintainability/configuration)

Description: Hardcoded file paths scattered throughout codebase. Extract as named constants in pkg/constants/ for centralized management.

Top Common Paths:

• .github/ (22 instances)
• /tmp/gh-aw/ (13 instances)
• .github/workflows/ (11 instances)
• /tmp/gh-aw/aw-prompts/prompt.txt (9 instances)
• ${RUNNER_TEMP}/gh-aw/mcp-config/mcp-servers.json (4 instances)

Affected Subsystems:

• pkg/workflow/ (30+ files)
• pkg/cli/ (15 files)
• pkg/parser/ (10 files)
• pkg/constants/

Action: Created issue #aw_hardcoded_paths

---

✅ Group 3: Code Quality – Function Length Refactoring

Findings: 658 instances across 387 files (functions >60 lines)

Severity: High (code maintainability, testability)

Description: Enforce 60-line function limit to improve readability, testability, and maintainability. This is a large backlog requiring a phased approach.

Top Offenders (line count):

1. buildPreActivationJob() – 489 lines
2. buildMainJob() – 411 lines
3. GetExecutionSteps() (codex_engine.go) – 385 lines
4. GetExecutionSteps() (antigravity_engine.go) – 205 lines
5. BuildAWFCommand() – 304 lines

Affected Subsystems:

• pkg/workflow/ (150+ functions) – primary focus
• pkg/cli/ (100+ functions) – secondary focus
• cmd/, pkg/parser/, pkg/github/

Refactoring Strategy:

1. Phase 1: Top 20 functions (>150 lines each) → ~3 agents
2. Phase 2: Medium functions (100–150 lines) → subsequent runs
3. Phase 3: Remaining functions (60–99 lines) → ongoing

Action: Created issue #aw_func_length

Minor Additional Findings:

• 1 × exec.CommandContext() missing (context cancellation)
• 1 × Deferred resource leak (file Close)

---

Summary Statistics

Category	Count	Files
map[string]bool sets	187	108
Hardcoded paths	120	55
Function length	658	387
Total	965	550+

---

Next Steps

1. ✅ Group 1 & 2: Ready for implementation. Use Copilot agents to remediate.
2. ✅ Group 3: Large backlog. Consider phased approach over multiple lint cycles.
3. 📋 Track progress via GitHub issues with lint-monster label.
4. 🔄 Re-run make golint-custom after each phase to validate.

Issues created:

• #[aw_map_set_opt] – map[string]bool optimization
• #[aw_hardcoded_paths] – hardcoded path constants
• #[aw_func_length] – function-length refactoring (658 items, phased)

Generated by 🧌 LintMonster · ◷

• expires on Jun 19, 2026, 4:57 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by LintMonster.

A newer discussion is available at Discussion #39947.