[daily-compiler-quality] Daily Compiler Code Quality Report - 2026-06-20

[github-actions[bot]]

🔍 Compiler Code Quality Analysis — 2026-06-20

Files Analyzed: compiler_orchestrator_engine.go, compiler_safe_outputs_job.go, compiler_yaml.go
Status: ⚠️ 2/3 files meet ≥75 threshold — compiler_yaml.go remains below

Executive Summary

All three files changed in commit 9ad5040. Changes are uniformly well-executed (magic-string → constants, map[string]bool → map[string]struct{}, clean feature additions). However, three large-function gaps flagged since 2026-06-14 remain unaddressed for the third consecutive cycle.

Overall codebase (9 files): avg 78.4/100, 7/9 files meeting the quality threshold — stable vs last run.

---

Summary Table

File	Score	Δ	Rating	Top Issue
compiler_orchestrator_engine.go	84/100	−1	✅ Good	applyEngineImportDefaults grew to 82L with 4× repeated JSON-unmarshal
compiler_safe_outputs_job.go	78/100	+1	✅ Good	buildSafeOutputsHandlerOutputsAndActionSteps 221L (tracked 3+ cycles)
compiler_yaml.go	73/100	+1	⚠️ Acceptable	generatePrompt 289L (tracked 3+ cycles); file growing to 1,089L

Avg (today): 78/100 · Files meeting threshold: 2/3

---

📁 Detailed Scores

compiler_orchestrator_engine.go — 84/100

Dimension	Score
Structure & Organization	22/25
Readability	15/20
Error Handling	17/20
Testing & Maintainability	17/20
Patterns & Best Practices	13/15

Strengths: MaxTurnCacheMisses addition mirrors existing budget-limit pattern exactly · enableFirewallByDefaultForPi follows copilot/Claude pattern · 100% %w error wrapping · test/source ratio improved to 1.52 (was 1.41)

Issues: applyEngineImportDefaults grew to 82L with 4× json.Unmarshal → parseMax* → assign blocks · comment density still low (~5.5%) · 6 bare return nil, err without context

Functions: 17 · Max fn: 82L · Avg fn: 30L · Comments: 5.5% · Tests: 1.52×

---

compiler_safe_outputs_job.go — 78/100

Dimension	Score
Structure & Organization	17/25
Readability	15/20
Error Handling	17/20
Testing & Maintainability	16/20
Patterns & Best Practices	13/15

Strengths: map[string]struct{} replaces map[string]bool for set deduplication (correct Go idiom) · constants.TmpGhAwDirSlash replaces 2 magic strings · removed unnecessary buildExtractBaseBranchStep · 27% comment density · 1.58× test ratio · 100% error wrapping

Issues: buildSafeOutputsJobFromParts 235L and buildSafeOutputsHandlerOutputsAndActionSteps 221L — both flagged every cycle since 2026-06-14 · buildJobLevelSafeOutputEnvVars 116L · file size 934L

Functions: 11 · Max fn: 235L · Avg fn: 85L · Comments: 27% · Tests: 1.58×

---

compiler_yaml.go — 73/100

Dimension	Score
Structure & Organization	15/25
Readability	14/20
Error Handling	17/20
Testing & Maintainability	15/20
Patterns & Best Practices	12/15

Strengths: constants.GithubDir replaces 2 magic ".github/" strings · CompilerVersion fallback is correct defensive code · new GH_AW_SAFE_OUTPUTS_URLS follows surrounding env-var pattern · 1.45× test ratio · 100% error wrapping

Issues: generatePrompt still 289L (flagged 3+ cycles, no progress) · file grew to 1,089L (+6 this cycle, +9 over last 2 cycles) · generateWorkflowHeader 176L · generateCreateAwInfo 174L with engine-ID switch that should be a map[string]string

Functions: 17 · Max fn: 289L · Avg fn: 64L · Comments: 17% · Tests: 1.45×

---

📈 All-Files Historical Scorecard

File	Score	Last Analyzed
compiler_orchestrator_tools.go	85/100 ✅	2026-06-13
compiler_orchestrator_engine.go	84/100 ✅	2026-06-20
compiler.go	82/100 ✅	2026-06-16
compiler_orchestrator_frontmatter.go	81/100 ✅	2026-06-19
compiler_jobs.go	79/100 ✅	2026-06-16
compiler_safe_outputs_job.go	78/100 ✅	2026-06-20
compiler_orchestrator_workflow.go	77/100 ✅	2026-06-19
compiler_yaml.go	73/100 ⚠️	2026-06-20
compiler_yaml_main_job.go	67/100 ⚠️	2026-06-19

Codebase avg: 78.4/100 · Meeting threshold: 7/9 (78%) — unchanged vs last run

Next rotation: compiler.go, compiler_jobs.go, compiler_yaml_main_job.go (priority: last two at 79/67)

---

Actionable Recommendations

High Priority

1. Extract JSON-unmarshal helper in applyEngineImportDefaults (compiler_orchestrator_engine.go)

   • Four identical json.Unmarshal → parse → assign if > 0 blocks; a applyMergedEngineIntLimit helper shrinks the function from 82L to ~40L
   • Est. effort: 30 min

2. Split generatePrompt (compiler_yaml.go)

   • 289L, flagged 3 consecutive cycles with no progress
   • Split points already marked by // Step 1a, // Step 1b, // Step 1.5, // Step 2 comments
   • Est. effort: 1–2 hours

Medium Priority

3. Split buildSafeOutputsJobFromParts into phase-based helpers — phase comments already exist
4. Extract engine-to-modelEnvVar map from generateCreateAwInfo switch into a map[string]string

Top 3 Issues

1. generatePrompt at 289L — chronic, 3+ cycles unaddressed
2. buildSafeOutputsHandlerOutputsAndActionSteps at 221L — chronic, 3+ cycles
3. 4× repeated JSON-unmarshal in applyEngineImportDefaults — new this cycle, easy to fix

Recommended Action

Extract the 4× JSON-unmarshal pattern in applyEngineImportDefaults into a generic helper (30 min, highest ROI today; also prevents the pattern from being copied again on the next budget-limit addition).

---

§27859033467 · Serena MCP + static analysis · Cache: /tmp/gh-aw/cache-memory/compiler-quality/

Generated by 📊 Daily Compiler Quality Check · 76.6 AIC · ⌖ 9.46 AIC · ⊞ 9.4K · ◷

• expires on Jun 20, 2026, 7:47 PM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-06-21T03:47:38.986Z.

Closed by Workflow