[Schema Consistency] 🔍 Schema Consistency Check - 2026-06-22 #40746
Closed
Replies: 1 comment
-
|
This discussion was automatically closed because it expired on 2026-06-23T07:10:10.783Z.
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
Critical Issues
engine.extensionsis implemented but missing from schema and generated reference docspkg/workflow/engine.go:497readsengine.extensionsand populatesconfig.Extensions;pkg/workflow/pi_engine.go:192andpkg/workflow/pi_engine.go:219use it to emitpi install <extension>steps.pkg/parser/schemas/main_workflow_schema.jsonhas no"extensions"property underengine/$defs.engine_config.docs/src/content/docs/reference/frontmatter-full.mdcontains noengine.extensionsentry even though it is generated from the schema.engine.idis schema-lax but runtime-strictengine.idfield is a plain string inpkg/parser/schemas/main_workflow_schema.json(around line 2041), with valid engines only implied in descriptions.pkg/workflow/engine_definition.go:268rejects unknown values withinvalid engine: ... Valid engines are: ....docs/src/content/docs/reference/engines.mdenumerates supported values (copilot,claude,codex,gemini,crush,opencode,pi).safe-outputs.dispatch-repositoryalias works in parser but is absent from schema/docspkg/workflow/dispatch_repository.go:30-39explicitly accepts bothdispatch_repositoryanddispatch-repository.dispatch_repositoryis declared inpkg/parser/schemas/main_workflow_schema.json:9137.Documentation Gaps
engine.extensions, proving the schema/docs pipeline is not capturing a live parser feature.dispatch_repository, not the accepted dashed alias.Schema Improvements Needed
engine.extensionsto$defs.engine_configwithtype: array, string items, and Pi-specific description/examples.enum(or equivalent constrained validation) forengine.id, or document intentionally broader acceptance if runtime prefix fallback is desired.dispatch-repositoryas an accepted alias in the schema/docs or remove parser support for it to keep a single canonical spelling.Parser Updates Required
dispatch-repositoryis meant to remain supported, make that alias explicit everywhere validation happens.engine.idwith the schema to avoid deferred compile errors.engine.extensions-style drift is caught automatically.Workflow Violations
Recommendations
engine.extensionsto the schema and regeneratefrontmatter-full.md.engine.idin schema to the same catalog enforced by the compiler, or clearly document the deliberate mismatch.additionalProperties: falseis used.Strategy Performance
Next Steps
engine.extensionsandengine.iddispatch_repositoryvsdispatch-repositoryReferences:
Beta Was this translation helpful? Give feedback.
All reactions