[terminal-stylist] Terminal Stylist Report: Console Output Analysis

[github-actions[bot]]

Overview

Analyzed 944 Go source files in pkg/ (excluding test files) for console output consistency, Lipgloss styling patterns, and Huh form implementations.

Key Metrics

Metric	Count
Go source files analyzed	944
Files using console.* package	~170
Files using Lipgloss directly	4 (outside styles/console)
Files importing Huh	13
Huh forms with WithTheme + WithAccessible	16/16 (100%)
Raw fmt.Fprintf(os.Stderr) without console formatting	~15 locations

✅ What Works Well

Adaptive Color System — pkg/styles/theme.go uses compat.AdaptiveColor for all colors, automatically selecting light/dark variants based on terminal background. The Dracula-inspired dark palette pairs with muted light variants for strong accessibility.

TTY Detection — applyStyle() in console.go consistently gates all styling via tty.IsStdoutTerminal() / tty.IsStderrTerminal(). Interactive components always check TTY before rendering forms.

Huh Theme Coverage — All 16 huh.NewForm() calls in pkg/cli/ apply .WithTheme(styles.HuhTheme).WithAccessible(console.IsAccessibleMode()). The HuhTheme maps all field states (focused, blurred, option, button, text input) to the Dracula palette. Accessibility mode checks ACCESSIBLE, TERM=dumb, and NO_COLOR environment variables.

Format/Render Naming Convention — The package doc clearly defines:

• Format* → pure string transformations, no side effects
• Render* → structured/multi-element layout output

This convention is followed consistently throughout.

Rust-like Error Rendering — FormatError() renders compiler errors with file:line:col: error: prefix, source code context lines, column pointer arrows (^^^), and optional hints. This is well-implemented and IDE-parseable.

Output Routing — Diagnostic output consistently goes to stderr; structured data (JSON, hashes) goes to stdout. The doc comment enforces this explicitly.

Logger Colors — pkg/logger/logger.go uses lipgloss.Fprintf with the shared styles.* adaptive color palette for namespace coloring.

Non-interactive Fallbacks — Interactive components (ConfirmAction, ShowInteractiveList, PromptSecretInput) gracefully fall back to plain-text alternatives when not in a TTY.

Lipgloss Direct Import Analysis

Four files outside pkg/styles and pkg/console import Lipgloss directly:

File	Reason	Assessment
pkg/cli/compile_schedule_calendar.go	Uses lipgloss.Style{} (empty style for non-TTY path) + styles.ScheduleCalendar* styles	✅ Justified — empty style cannot be a constant
pkg/cli/mcp_inspect.go	Imports charm.land/lipgloss/v2/tree for tree rendering	✅ Justified — tree sub-package
pkg/cli/status_command.go	Imports charm.land/lipgloss/v2/tree for tree rendering	✅ Justified — tree sub-package
pkg/logger/logger.go	Uses lipgloss.Fprintf and inline style palette	⚠️ Minor: palette styles could be defined in pkg/styles for centralization

Huh Form Implementation Review

• Field types used: huh.NewSelect, huh.NewInput, huh.NewConfirm, huh.NewMultiSelect
• Validation: PromptSecretInput validates for non-empty; engine/git forms validate option selections
• Keyboard navigation: Inherited from huh defaults; search/filter enabled on workflow selector with Filtering(true) and Height(15)
• Accessibility: console.IsAccessibleMode() is called uniformly across all forms
• Theming: styles.HuhTheme maps all huh style slots (Focused, Blurred, Group, TextInput) to the Dracula palette

Standalone wrappers in pkg/console:

• ConfirmAction() — wraps huh.NewConfirm with TTY fallback
• PromptSecretInput() — wraps huh.NewInput with EchoModePassword
• ShowInteractiveList() — wraps huh.NewSelect with text fallback

All three apply styles.HuhTheme and IsAccessibleMode().

⚠️ Areas Needing Improvement

1. Raw fmt.Fprintf(os.Stderr) Without Console Formatting

Several files write directly to stderr with plain string prefixes ("Warning: ", "ERROR: ", "WARNING: ") instead of using the console.FormatWarningMessage() / console.FormatErrorMessage() helpers:

File	Lines	Issue
pkg/workflow/claude_logs.go	155, 216, 226, 232, 279, 326	Raw verbose diagnostics, no console formatting
pkg/workflow/cache.go	379	"Warning: " string prefix instead of FormatWarningMessage
pkg/workflow/mcp_renderer.go	98	"Error generating..." without FormatErrorMessage
pkg/workflow/compiler_orchestrator_engine.go	220, 226	"WARNING: " all-caps prefix
pkg/workflow/push_to_pull_request_branch.go	117	"Warning: " string prefix
pkg/workflow/side_repo_maintenance.go	149, 173	Raw info messages without formatting
pkg/workflow/lock_validation.go	109–110	Raw SHA detail lines (verbose mode)
pkg/cli/vscode_config.go	82	Raw info message
pkg/cli/trial_confirmation.go	182–222	Checklist items mixed with blank fmt.Fprintln(os.Stderr, "")

Example anti-pattern:

// ❌ Anti-pattern
fmt.Fprintf(os.Stderr, "Warning: Failed to parse cache configuration: %v\n", err)

// ✅ Preferred
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to parse cache configuration: %v", err)))

2. Mixed Formatting in pkg/cli/compile_stats.go

This file mixes console.Format* calls with raw fmt.Fprintf(os.Stderr, ...) in adjacent lines, creating inconsistent visual output:

// Line 158: ✅ Uses console
fmt.Fprintln(os.Stderr, console.FormatErrorMessage(summary))

// Line 165: ❌ Raw - no console formatting
fmt.Fprintf(os.Stderr, "  ✗ %s\n", filepath.Base(failure.Path))

// Line 186: ❌ Raw - uses icon emoji manually
fmt.Fprintf(os.Stderr, "  %s %s:\n", prioritized.Severity.Icon(), heading)

The list items ( ✗ %s) should use console.FormatListItem(). The verbose detail lines could use console.FormatVerboseMessage().

3. Verbose Diagnostics in pkg/workflow/claude_logs.go

The verbose flag paths bypass console formatting entirely:

// ❌ Anti-pattern — raw format string
if verbose {
    fmt.Fprintf(os.Stderr, "Failed to parse Claude log as JSON array, trying JSONL format: %v\n", err)
}

// ✅ Preferred — use console.LogVerbose helper
console.LogVerbose(verbose, fmt.Sprintf("Failed to parse Claude log as JSON array, trying JSONL format: %v", err))

console.LogVerbose(verbose, message) already exists for exactly this purpose.

Recommendations

1. Replace raw "Warning:" / "ERROR:" prefixes with console.FormatWarningMessage() / console.FormatErrorMessage() in the 9 files listed above.

2. Migrate verbose diagnostic paths in pkg/workflow/claude_logs.go to use console.LogVerbose(verbose, msg) instead of bare fmt.Fprintf(os.Stderr, ...) calls.

3. Standardize list items in compile_stats.go — use console.FormatListItem() for " ✗ %s" entries and console.FormatVerboseMessage() for suppressed-count and show-all guidance lines.

4. Consider moving logger palette to pkg/styles — the colorPalette slice in pkg/logger/logger.go duplicates what pkg/styles already exposes. Moving it centralizes all color definitions.

5. No action needed on Huh forms — theme and accessibility coverage is 100% consistent.

References:

• §28017691700

Generated by 💄 Terminal Stylist · 91.6 AIC · ⌖ 14 AIC · ⊞ 5.6K · ◷

• expires on Jun 24, 2026, 2:01 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-06-24T10:01:32.928Z.

Closed by Workflow