[typist] 🔤 Typist — Go Type Consistency Analysis

[github-actions[bot]]

Analysis of repository: github/gh-aw — 944 non-test .go files under pkg/, 833 struct definitions.

Executive Summary

Good news first: gh-aw is a well-typed codebase. The overwhelming majority of interface{}/any usage (~2,125 map[string]any, 1,455 of them in pkg/workflow) is legitimate — it's how the compiler parses dynamic YAML frontmatter, where map[string]any is the idiomatic right call. The code already defines named string types (EngineName, FeatureFlag, JobName, MCPServerID, GitHubIntegrityLevel), so strong typing is clearly valued.

The real (small) wins: a handful of exact-field duplicate structs that are near-zero-risk deletions, one clear consistency bug (a string field that should reuse the existing GitHubIntegrityLevel enum), and several enum-like const clusters that would gain compile-time safety from a one-line named type. Exact same-name collisions are all intentional _wasm.go build-tag variants or type X = pkg.X aliases — not real duplication. Fixing the exact duplicates plus the LLMProvider/GitHubIntegrityLevel typing are the highest-leverage moves. A tidy codebase that could get a little tidier. 🙂

Full Analysis Report

Duplicated Types — 10 real clusters (3 exact, 5 near, 2 low-value)

Exact-field duplicates (delete / merge — lowest risk):

1. Experiment state — pkg/cli/experiments_command.go:34 ExperimentState / :40 ExperimentRunRecord are byte-identical (incl. JSON tags) to the unexported experimentStateJSON/experimentRunRecord at pkg/cli/audit_report_experiments.go:35/:42, same package. Both model pick_experiment.cjs's state.json. → Delete the unexported pair, reuse the exported.
2. Engine log response — pkg/workflow/antigravity_logs.go:14 AntigravityResponse and pkg/workflow/gemini_logs.go:14 GeminiResponse are 100% identical (Response string, Stats map[string]any), and their ParseLogMetrics methods are near-identical. → Extract one shared CLIJSONResponse.
3. Container pin — pkg/actionpins/actionpins.go:46 ContainerPin ≡ pkg/workflow/safe_update_manifest.go:33 GHAWManifestContainer (Image/Digest/PinnedImage, only omitempty differs). → Reuse ContainerPin or alias it.
4. Local dup — releaseWithVersion is declared as a function-local type twice in the same file (pkg/cli/update_actions.go:324 and :458). → Hoist to one package-level type.

Near-duplicate clusters (embed a shared base)

• Pinned-action record — actionpins.go:38 ActionPin ⊃ safe_update_manifest.go:24 GHAWManifestAction (Repo/Version/SHA). Manifest type should embed ActionPin.
• Token counts — pkg/cli/token_usage.go:74 ModelTokenUsage, :89 ModelTokenUsageRow, :382 agentUsageEntry all share Input/Output/CacheRead/CacheWriteTokens; AIC vs AICredits is the same concept twice. → Extract embedded TokenCounts.
• Secret spec ⊂ requirement — pkg/constants/engine_constants.go:134 SystemSecretSpec is a 4-field subset of pkg/cli/engine_secrets.go:27 SecretRequirement. → Use []SecretRequirement.
• Summaries — pkg/cli/logs_models.go:147 MissingToolSummary ↔ :167 MissingDataSummary share 6/7 fields (differ only by Tool vs DataType). → Shared summaryAggregateBase.
• Action input — generate_action_metadata_command.go:46 ActionInput ↔ actionpins.go:31 ActionYAMLInput share Description/Required/Default.
• Low-value: dependabot.go:58/64/70 NpmDependency/PipDependency/GoDependency → one Dependency; update_types.go:11/17 casing-only dup; audit_comparison.go:44/50 Int/String delta → generic Delta[T].

Rejected false positives: engine wrappers (already embed BaseEngine), MCP layer types (already embed BaseMCPServerConfig), per-tool finding structs, domain stats, diff entries — distinct concepts.

Untyped Usages

Category 1 — field that should be a concrete type (consistency bug, 1-line fix):

• pkg/workflow/tools_types.go:368 EndorserMinIntegrity string → GitHubIntegrityLevel. Its sibling MinIntegrity GitHubIntegrityLevel (:325) already uses the named type (defined :287-297) for the same "approved"/"unapproved"/"merged" domain.

Other any struct fields (RunsOn, Imports, Include, Headers, Engine, ...) are deliberately polymorphic YAML unions and correctly left as any.

Category 2 — const enum clusters → named string types (strongest category):

Location	Suggested type	Note
pkg/workflow/llm_provider.go:10-14	type LLMProvider string	Strongest. engine.go:49 EngineConfig.LLMProvider string + many provider string params would all become typed across routing logic.
pkg/cli/mcp_registry_types.go:107-110	MCPServerStatus	2-value status.
pkg/cli/mcp_registry_types.go:113-116	MCPArgumentType	2-value kind.
pkg/cli/outcomes_history.go:19-23	historySource	Filter mode.
pkg/cli/env_command.go:24-28	defaultsScope	repo/org/ent.
pkg/cli/logs_safe_output_chains.go:16-20	temporaryIDMapStatus	Stored in a struct field.
pkg/cli/token_usage.go:122-123	modelMismatchReason	2-value reason.

Category 3 — any params/returns: few clean wins; most read from a map[string]any node so any is the correct boundary. Marginal: dependabot.go:559/586 normalizers, stringutil.go:54 ParseVersionValue.

Category 4 — type-assertion clusters → typed parse structs w/ UnmarshalYAML:

• pkg/workflow/observability_otlp.go:523-556 and :599-632 — endpoint union asserted in two duplicated functions → OTLPEndpoint.
• pkg/workflow/role_checks.go:100-213 → OnEventConfig{Roles, Bots, Labels []string}.
• pkg/workflow/stop_after.go:447-486 → SkipIfCheckFailingConfig.
• pkg/workflow/compiler_jobs.go:758-809 → JobConfig{Timeout, Concurrency}.

🎯 Recommended Actions (impact ÷ effort)

1. Priority 1 (~3-4 hrs, high): delete exact-field dups (clusters 1–4 above) — zero field-drift risk.
2. Priority 2 (~2-3 hrs, high): fix EndorserMinIntegrity → GitHubIntegrityLevel; add type LLMProvider string.
3. Priority 3 (~2-3 hrs, medium): named string types for the pkg/cli enum clusters.
4. Priority 4 (1-2 hrs each, medium): typed parse structs for the 4 assertion clusters (also de-dups OTLP).

Run make test after each change.

Detection: Serena semantic analysis + ripgrep + parallel agent verification. Date: 2026-06-23.

Generated by ✍️ Typist - Go Type Analysis · 695.3 AIC · ⌖ 10.1 AIC · ⊞ 6.3K · ◷

• expires on Jun 24, 2026, 4:34 AM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Typist - Go Type Analysis.

A newer discussion is available at Discussion #41218.