[sergo] Sergo Report: Registry-Delta-38 + Enforce-Readiness Batch - 2026-06-30

[github-actions[bot]]

Executive Summary

Run R52 detected a registry delta (37 → 38 analyzers), freshly audited the new 38th linter errortypeassertion, and filed one enforce-readiness issue promoting two type-resolved, zero-violation context/error-family linters into the blocking CI gate.

• Registry: grep -c 'Analyzer' cmd/linters/main.go = 38 (was 37). New 38th = errortypeassertion (main.go:65, ADR docs/adr/42323).
• Audit verdict: errortypeassertion is CLEAN — fully type-resolved, parity-complete, zero production violations.
• Issue: 1 created (#42416). Reconcile: R51's #aw_sg51a1 landed as hardcodedfilepath: hasFormatVerb verb-set too narrow — format-template paths using %x/%t/%c/%g escape exclusion (latent FP) #42174 (open).

Tool / Registry Updates

Signal	Last run (R51)	This run (R52)
Serena LSP tools	23	23 (stable)
Registered analyzers	37	38
New linter	osgetenvlibrary	errortypeassertion
doc.go header	"30 active"	"30 active" (drift, #40436)

Strategy — strict 50/50 split

Cached component (proven): registry-delta detector (grep -c Analyzer vs prior) + open-issue reconcile via gh api ...labels=sergo. This is the highest-yield repeatable move and immediately surfaced the new 38th linter and the #42174 landing.

New exploration: fresh deep-audit of the never-seen errortypeassertion, plus an enforce-readiness sweep of the two newest context/error-family linters against the curated 14-linter blocking gate in cgo.yml:1208 — a novel cross-cut of "new linter" × "CI enforcement gap."

Run targets: 1 type-resolved audit verdict, ≥1 zero-risk actionable issue, no duplicates. All met.

Findings

F1 — New 38th linter errortypeassertion: CLEAN (type-resolved)

pkg/linters/errortypeassertion/errortypeassertion.go:

• Gates on types.Identical(TypeOf(X), builtinError) (:71-74, :101-103) — no syntactic identifier matching, so it avoids the syntactic_stdlib_match FP/FN class entirely.
• Excludes interface assertion targets (:80-82, :121-123) and named interfaces embedding error (documented design, :67-70).
• Covers both *ast.TypeAssertExpr and *ast.TypeSwitchStmt (:43-50), including comma-ok and switch x := err.(type) init forms (typeSwitchX :135-148).
• Full suppression parity: nolint.BuildLineIndex/HasDirective + filecheck.IsTestFile.

No FP/FN class identified. Consistent with the team's disciplined linter quality.

F2 — Enforce-readiness gap: 2 linters ready but outside the blocking gate

The blocking gate (cgo.yml:1208) enforces a curated 14 linters with -test=false. make golint-custom with no flags runs all 38 but is only the advisory lint-monster path, not a hard gate.

• errortypeassertion — new, type-resolved, parity-complete, 0 prod violations. Never proposed for enforcement.
• execcommandwithoutcontext — prerequisites done under closed execcommandwithoutcontext enforce-readiness: propagate context in connectStdioMCPServer (2 sites), add nolint support, then enfo [Content truncated due to length] #38282 (2 connectStdioMCPServer sites fixed + nolint added); now type-resolved (ObjectOf→PkgName os/exec, :94-114) with autofix, 0 prod violations, but the final "then enforce" step was never landed.

F3 — Zero-violation evidence (gate scope ./cmd/... ./pkg/...)

• errortypeassertion: every prod .(*T) targets *ast.*/*types.* (typed ast.Node/types.Type), never built-in error; lone custom-iface assertion pkg/parser/json_path_locator.go:111 is not on error. No cmd/ matches.
• execcommandwithoutcontext: every prod exec.Command( sits in a non-ctx function (remote_fetch.go downloadFileViaGitClone/resolveRefToSHAViaGit, pip_validation.go validate*WithPip, dependabot.go:339); the two ctx-receiving funcs (downloadFileViaGit, downloadFileViaRawURL) contain none. No cmd/ matches.

F4 — Reconcile

• R51 #aw_sg51a1 → landed as hardcodedfilepath: hasFormatVerb verb-set too narrow — format-template paths using %x/%t/%c/%g escape exclusion (latent FP) #42174 (hardcodedfilepath hasFormatVerb narrow), OPEN.
• nolint parity gap: 4 non-enforced context-family linters have no internal/nolint suppression (execcommandwithoutcontext, ctxback [Content truncated due to length] #41377 (open, nolint parity for context-family) is now partially obsolete for execcommandwithoutcontext, which already wires nolint.
• doc.go still reads "30 active" (header drift, doc-sync: pkg/linters/doc.go says "29 active analyzers" but 30 are registered — list omits hardcodedfilepath and sprintferrdot #40436 family) — known, not refiled.

Generated Task

T1 — Promote errortypeassertion + execcommandwithoutcontext into the cgo.yml blocking gate. Single-line change: append -errortypeassertion -execcommandwithoutcontext to LINTER_FLAGS at cgo.yml:1208. Zero current violations → pure regression guard. Validation: run each linter standalone clean, then confirm the gate stays green. Effort: Small. → Filed as #42416.

Metrics

Metric	Value
Findings	5
Tasks generated	1
Issues created	1 (#42416)
Duplicates skipped	#42174, #41377, #40436 (reconciled, not refiled)
Success score	8 / 10

Historical Context

Enforce-readiness issues following this exact template have a strong landing record: #39324 (timesleepnocontext), #39016 (httpnoctx), #38282 (execcommandwithoutcontext prereqs) — all acted on and closed. Cumulative: 52 runs, 362 findings, 100 tasks, avg score 8.78.

Recommendations & Next-Run Focus (R53)

• Watch for the 39th analyzer (grep -c Analyzer main.go vs 38) + doc.go-omitted-minus-known.
• Reconcile #42416 and #42174.
• Fresh never-deep-audited targets: seenmapbool (seenmapbool: duplicate diagnostics for set-maps declared inside function literals (double AST traversal) #40733 double-report), errstringmatch (errstringmatch coverage gap: only strings.Contains(err.Error(), ...) is flagged — HasPrefix/HasSuffix/EqualFold/Index on err.Err [Content truncated due to length] #40244 Contains-only), other hardcodedfilepath funcs.
• Prefer single-file precision, 1–2 issues/run.

References:

• §28421420974

Generated by 🤖 Sergo - Serena Go Expert · 294.5 AIC · ⌖ 13.4 AIC · ⊞ 5.9K · ◷

• expires on Jun 30, 2026, 9:13 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Sergo - Serena Go Expert.

A newer discussion is available at Discussion #42646.