[repository-quality] Repository Quality Improvement Report — ADR-42150: dispatch-repository Key Canonicalization

[github-actions[bot]]

🎯 Repository Quality Improvement Report — ADR-42150 Implementation Gap

Analysis Date: 2026-07-03
Focus Area: ADR-42150 — dispatch-repository Key Canonicalization
Strategy Type: Custom (run 32/32, 72% custom rate)

Executive Summary

ADR-42150 decided dispatch-repository (hyphen) is the canonical safe-output key. Three pieces are already done: the safe-output-dispatch-repository-key codemod, the JSON schema alias, and the runtime parser. However the core source-of-truth fields — the SafeOutputsConfig yaml struct tag, the handler registry key in GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG, user-facing validation error messages, and agent docs — still use the underscore form. The ADR cannot advance from Draft to Accepted until these 7 gaps are closed.

Five targeted tasks below complete the canonicalization. Tasks 1–2 carry zero runtime risk; Task 3 requires verifying firewall handler-config compatibility.

Full Analysis Report

Metrics Collected:

Artefact	Current	Status
SafeOutputsConfig yaml tag (safe_outputs_config.go:74)	dispatch_repository	❌
Handler registry key (safe_outputs_handler_registry.go:654)	dispatch_repository	❌
samples_validation.go skip-list (:48)	dispatch_repository	❌
Validation error messages (dispatch_repository_validation.go, 8×)	underscore in strings	❌
Compiler validator log (compiler_validators.go:374)	dispatch_repository	❌
.github/aw/safe-outputs-automation.md	underscore "preferred"	❌
test-copilot-dispatch-repository.md	underscore	❌
JSON schema alias	✅ done	✅
Runtime parser lookup order	✅ done	✅
Codemod safe-output-dispatch-repository-key	✅ ships v1.0.65	✅

Areas for Improvement

• [HIGH] SafeOutputsConfig struct tag is yaml:"dispatch_repository,omitempty" — affects yaml.Marshal round-trips.
• [HIGH] Handler registry key "dispatch_repository" is emitted into GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG — the runtime contract.
• [HIGH] 8 user-facing error strings in dispatch_repository_validation.go show deprecated form in example YAML snippets.
• [MEDIUM] samples_validation.go skip-list uses underscore — will mismatch if runtime key changes.
• [MEDIUM] .github/aw/safe-outputs-automation.md says dispatch_repository (underscore, preferred) — contradicts ADR.
• [LOW] Test workflow uses old key form.

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Task 1: Update validation error messages to use dispatch-repository

Priority: High | Effort: Small

Description: 8+ fmt.Errorf and log strings in dispatch_repository_validation.go and compiler_validators.go show the deprecated underscore form in example YAML snippets shown to users.

Acceptance Criteria:

• All string literals in pkg/workflow/dispatch_repository_validation.go use dispatch-repository: in message prefixes and YAML examples
• newValidationLogger("dispatch_repository") → newValidationLogger("dispatch-repository")
• compiler_validators.go:374 logMessage and errPrefix use dispatch-repository
• make agent-report-progress passes

Code Region: pkg/workflow/dispatch_repository_validation.go, pkg/workflow/compiler_validators.go

In `pkg/workflow/dispatch_repository_validation.go`, replace every `dispatch_repository` occurrence in Go string literals (fmt.Errorf, log Print, YAML examples) with `dispatch-repository`. Do NOT rename Go identifiers like `validateDispatchRepository` or `dispatchRepositoryValidationLog`.

In `pkg/workflow/compiler_validators.go` (~line 374):
- `"Validating dispatch_repository configuration"` → `"Validating dispatch-repository configuration"`
- `"dispatch_repository validation failed: "` → `"dispatch-repository validation failed: "`

Run `make agent-report-progress`.

---

Task 2: Update SafeOutputsConfig yaml tag and samples_validation key

Priority: High | Effort: Small

Acceptance Criteria:

• pkg/workflow/safe_outputs_config.go:74 yaml tag is yaml:"dispatch-repository,omitempty"
• pkg/workflow/samples_validation.go:48 entry is "dispatch-repository": true
• go test ./pkg/workflow/... -count=1 passes

Code Region: pkg/workflow/safe_outputs_config.go, pkg/workflow/samples_validation.go

In `pkg/workflow/safe_outputs_config.go` (~line 74): change `yaml:"dispatch_repository,omitempty"` to `yaml:"dispatch-repository,omitempty"`.

In `pkg/workflow/samples_validation.go`: change `"dispatch_repository": true` to `"dispatch-repository": true` in the `noSequenceTypes` map.

Run `go test ./pkg/workflow/... -count=1` then `make agent-report-progress`.

---

Task 3: Rename handler registry key to dispatch-repository

Priority: Medium | Effort: Medium

Acceptance Criteria:

• pkg/workflow/safe_outputs_handler_registry.go:654 key is "dispatch-repository"
• pkg/workflow/safe_outputs_tools_generation.go log/comments use dispatch-repository
• pkg/workflow/safe_outputs_config.go:496 comment updated
• go test ./pkg/workflow/... -count=1 passes

Code Region: pkg/workflow/safe_outputs_handler_registry.go, pkg/workflow/safe_outputs_tools_generation.go

In `pkg/workflow/safe_outputs_handler_registry.go`: rename map key `"dispatch_repository"` (~line 654) to `"dispatch-repository"`.

In `pkg/workflow/safe_outputs_tools_generation.go`: update comment and log string from `dispatch_repository` to `dispatch-repository`.

In `pkg/workflow/safe_outputs_config.go` (~line 496): update comment `// Handle dispatch_repository` to `// Handle dispatch-repository`.

Run `go test ./pkg/workflow/... -count=1` then `make agent-report-progress`.

---

Task 4: Update .github/aw/safe-outputs-automation.md to canonical key

Priority: Medium | Effort: Small

Acceptance Criteria:

• All examples use dispatch-repository: (hyphen)
• Deprecation note: dispatch_repository is a deprecated alias; run gh aw fix
• make agent-report-progress passes

Code Region: .github/aw/safe-outputs-automation.md

In `.github/aw/safe-outputs-automation.md`:
1. Change `dispatch_repository:` to `dispatch-repository:` in the feature list and YAML example.
2. Replace: `Accepts both \`dispatch_repository\` (underscore, preferred) and \`dispatch-repository\` (dash).`
   With: `Use \`dispatch-repository:\` (hyphen) as the canonical key. \`dispatch_repository\` (underscore) is a deprecated alias — run \`gh aw fix\` to migrate.`

Run `make agent-report-progress`.

---

Task 5: Migrate test workflow and accept ADR-42150

Priority: Low | Effort: Small

Acceptance Criteria:

• pkg/cli/workflows/test-copilot-dispatch-repository.md uses dispatch-repository: key
• docs/adr/42150-make-dispatch-repository-canonical-safe-output-key.md status is Accepted
• make recompile passes

Code Region: pkg/cli/workflows/test-copilot-dispatch-repository.md, docs/adr/42150-make-dispatch-repository-canonical-safe-output-key.md

1. In `pkg/cli/workflows/test-copilot-dispatch-repository.md`: rename `dispatch_repository:` to `dispatch-repository:` in frontmatter.
2. In `docs/adr/42150-make-dispatch-repository-canonical-safe-output-key.md`: change `**Status**: Draft` to `**Status**: Accepted`.
3. Run `make recompile` then `make agent-report-progress`.

---

📊 Historical Context

Previous 5 Focus Areas

Date	Area	Custom
2026-06-29	tolowerequalfold Linter False Positives	Y
2026-06-30	Unauthenticated API Fallback Chain	Y
2026-07-01	Codemod Registry Drift	Y
2026-07-02	Remote Fetch API Context Gap	Y
2026-07-03	ADR-42150 dispatch-repository Canonicalization	Y

---

🎯 Recommendations

Immediate Actions (This Week)

1. Fix validation error messages (Task 1) — Priority: High
2. Update struct yaml tag + samples_validation (Task 2) — Priority: High

Short-term Actions (This Month)

1. Rename handler registry key (Task 3) — Priority: Medium
2. Update safe-outputs-automation.md (Task 4) — Priority: Medium

Long-term Actions

1. Migrate test workflow and accept ADR (Task 5) — Priority: Low

---

📈 Success Metrics

• Underscore in user-facing strings: 10 → 0
• Handler registry key: dispatch_repository → dispatch-repository
• ADR-42150 status: Draft → Accepted

---

References:

• §28663341769 — This analysis run
• docs/adr/42150-... — ADR-42150 (Draft)

Generated by ⚡ Repository Quality Improvement Agent · 212.4 AIC · ⌖ 6.15 AIC · ⊞ 6.7K · ◷

• expires on Jul 4, 2026, 5:39 AM UTC-08:00