Skip to content

[code-scanning-fix] Fix go/unsafe-quoting: Remove unused environment variable with unsafe JSON embedding #11424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 2 commits into from
+0 −14
Closed

[code-scanning-fix] Fix go/unsafe-quoting: Remove unused environment variable with unsafe JSON embedding #11424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7636d75
fix(security): Remove unused environment variable with unsafe JSON qu…
Jan 23, 2026
ba457fa
Initial plan (#11426)
Copilot Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions pkg/workflow/update_project_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package workflow

import (
"encoding/json"
"fmt"
)

Expand Down Expand Up @@ -38,19 +37,6 @@ func (c *Compiler) buildUpdateProjectJob(data *WorkflowData, mainJobName string)
// The JavaScript code checks process.env.GH_AW_PROJECT_GITHUB_TOKEN to provide helpful error messages
customEnvVars = append(customEnvVars, fmt.Sprintf(" GH_AW_PROJECT_GITHUB_TOKEN: %s\n", effectiveToken))

// If views are configured in frontmatter, pass them to the JavaScript via environment variable
if data.SafeOutputs.UpdateProjects != nil && len(data.SafeOutputs.UpdateProjects.Views) > 0 {
viewsJSON, err := json.Marshal(data.SafeOutputs.UpdateProjects.Views)
if err != nil {
return nil, fmt.Errorf("failed to marshal views configuration: %w", err)
}
// lgtm[go/unsafe-quoting] - This generates YAML environment variable declarations, not shell commands.
// The %q format specifier properly escapes the JSON string for YAML syntax. There is no shell injection
// risk because this value is set as an environment variable in the GitHub Actions YAML configuration,
// not executed as shell code.
customEnvVars = append(customEnvVars, fmt.Sprintf(" GH_AW_PROJECT_VIEWS: %q\n", string(viewsJSON)))
}

jobCondition := BuildSafeOutputType("update_project")
permissions := NewPermissionsContentsReadProjectsWrite()

Expand Down
Loading