Skip to content

Conversation

@JessRudder
Copy link
Contributor

@JessRudder JessRudder commented Oct 15, 2024

Closes https://github.com/github/models/issues/321

This PR updates the --help output for the following:

gh models --help
gh models list --help
gh models view --help
gh models run --help

In order to make it easier to format the longer string I've included the heredoc module.

The contents that I wrote are a rough draft based on my basic understanding of how things work and what's helpful to include in the docs. Please provide feedback on the content!

Some specific points I'd like feedback on (though all feedback is welcome):

  1. Is the wording clear and concise?
  2. Should we mention Azure at all (also, am I even correct that this is coming from Azure)? Consensus is no.
  3. Are there rate limits/limitations on certain commands that I should include in the output?
  4. I followed some other gh CLIs and mentioned https://cli.github.com/manual/gh_models - will we actually have docs there (like codespace and other extensions do)? Using the readme for the extension for now, can change later if we end up in the online manual.

@JessRudder JessRudder self-assigned this Oct 15, 2024
@JessRudder JessRudder marked this pull request as ready for review October 17, 2024 17:06
@JessRudder JessRudder requested a review from a team as a code owner October 17, 2024 17:06
Copy link
Member

@cheshire137 cheshire137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Christopher about dropping the API request mentions.

JessRudder and others added 5 commits October 18, 2024 11:08
Co-authored-by: Sarah Vessels <82317+cheshire137@users.noreply.github.com>
Co-authored-by: Sarah Vessels <82317+cheshire137@users.noreply.github.com>
Co-authored-by: Sarah Vessels <82317+cheshire137@users.noreply.github.com>
Co-authored-by: Sarah Vessels <82317+cheshire137@users.noreply.github.com>
Copy link
Member

@cschleiden cschleiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JessRudder JessRudder merged commit 516aef5 into main Oct 18, 2024
2 checks passed
@JessRudder JessRudder deleted the jessrudder/update-help-message branch October 18, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants